This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Move handling of the target triple to the DSL
ClosedPublic

Authored by ldionne on May 6 2021, 11:24 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Restricted Project
Restricted Project
Commits
rG74d096e55879: [libc++] Move handling of the target triple to the DSL
Summary

This fixes a long standing issue where the triple is not always set
consistently in all configurations. This will be necessary for using
from scratch Lit configuration files.

Diff Detail

Event Timeline

ldionne created this revision.May 6 2021, 11:24 AM
ldionne requested review of this revision.May 6 2021, 11:24 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMay 6 2021, 11:24 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne updated this revision to Diff 343486.May 6 2021, 1:10 PM

Try to fix backdeployment issues.

ldionne updated this revision to Diff 343497.May 6 2021, 2:05 PM

Workaround gcc apparently not support --target=XXX.

ldionne updated this revision to Diff 343673.May 7 2021, 7:21 AM
ldionne retitled this revision from [libc++] Refactor how we set the target triple to [libc++] Move handling of the target triple to the DSL.
ldionne edited the summary of this revision. (Show Details)

Split into two changes - this is the target change only

Herald added a project: Restricted Project. · View Herald TranscriptMay 7 2021, 7:21 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne updated this revision to Diff 343719.May 7 2021, 10:44 AM

Merge both changes

ldionne updated this revision to Diff 343734.May 7 2021, 11:59 AM

Fix libc++abi failure in the legacy builds

ldionne updated this revision to Diff 343830.May 8 2021, 4:41 AM

Fix libcxxabi issue.

ldionne accepted this revision.May 8 2021, 8:10 AM
This revision was not accepted when it landed; it landed in state Needs Review.May 8 2021, 8:11 AM
This revision was automatically updated to reflect the committed changes.