This is an archive of the discontinued LLVM Phabricator instance.

Fix hanging test suite when dosep.py is invoked directly.
ClosedPublic

Authored by chaoren on May 29 2015, 11:24 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

chaoren updated this revision to Diff 26802.May 29 2015, 11:24 AM
chaoren retitled this revision from to Fix hanging test suite when dosep.py is invoked directly..
chaoren updated this object.
chaoren edited the test plan for this revision. (Show Details)
chaoren added reviewers: zturner, sivachandra.
chaoren added a subscriber: Unknown Object (MLST).

I remember we ran into this same problem when I first wrote the timeout code. which is why the stdin=subprocess.PIPE was originally there.

zturner edited edge metadata.May 29 2015, 11:27 AM

lgtm if you say this fixes it. But do you know why the stdin=subprocess.PIPE necessary? The subprocess should never even receive any stdin should it?

This revision was automatically updated to reflect the committed changes.