This is an archive of the discontinued LLVM Phabricator instance.

[mips] Add RuntimeDyld tests for currently supported O32 relocations.
ClosedPublic

Authored by dsanders on May 29 2015, 9:13 AM.

Diff Detail

Event Timeline

dsanders updated this revision to Diff 26786.May 29 2015, 9:13 AM
dsanders retitled this revision from to [mips] Add RuntimeDyld tests for currently supported O32 relocations..
dsanders updated this object.
dsanders edited the test plan for this revision. (Show Details)
dsanders added a reviewer: petarj.
dsanders added a subscriber: Unknown Object (MLST).
vkalintiris accepted this revision.Jun 2 2015, 5:05 AM
vkalintiris added a reviewer: vkalintiris.
vkalintiris added a subscriber: vkalintiris.

LGTM

test/ExecutionEngine/RuntimeDyld/Mips/ELF_O32_PIC_relocations.s
3

change %/T to %T in order to be consistent and avoid needless canonicalization.

5–7

Do we want to keep these lines (disabled) for future reference?

This revision is now accepted and ready to land.Jun 2 2015, 5:05 AM
dsanders added inline comments.Jun 2 2015, 6:45 AM
test/ExecutionEngine/RuntimeDyld/Mips/ELF_O32_PIC_relocations.s
3

I've made this change but I may have to change it back if the windows buildbots complain.

5–7

I'll delete them for now and bring them back when big-endian works.

dsanders closed this revision.Jun 2 2015, 8:05 AM