Page MenuHomePhabricator

Fix race in IOHandlerProcessSTDIO
ClosedPublic

Authored by labath on May 27 2015, 7:07 AM.

Details

Summary

IOHandlerProcessSTDIO::Run() was opening the pipe for interrupt requests lazily. This was racing
with another thread executing IOHandlerProcessSTDIO::Cancel() simultaneously. I fix this by
opening the pipe in the object constructor. The pipe will be automatically closed when the object
is destroyed.

Diff Detail

Repository
rL LLVM

Event Timeline

labath updated this revision to Diff 26593.May 27 2015, 7:07 AM
labath retitled this revision from to Fix race in IOHandlerProcessSTDIO.
labath updated this object.
labath edited the test plan for this revision. (Show Details)
labath added reviewers: clayborg, ribrdb.
labath added a subscriber: Unknown Object (MLST).
clayborg accepted this revision.May 27 2015, 9:52 AM
clayborg edited edge metadata.

Looks good.

This revision is now accepted and ready to land.May 27 2015, 9:52 AM
This revision was automatically updated to reflect the committed changes.