This is an archive of the discontinued LLVM Phabricator instance.

Differential D100129

Tiny format fix
ClosedPublic

Authored by urnathan on Apr 8 2021, 10:48 AM.

Details

Reviewers
rsmith
bruno
• Quuxplusone
Commits
rG92498264269c: [clang] Tiny format fix
Summary

A mis-indented } in the middle of a function.

Diff Detail

Event Timeline

urnathan requested review of this revision.Apr 8 2021, 10:48 AM
urnathan created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptApr 8 2021, 10:48 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B97778: Diff 336168.Apr 8 2021, 11:40 AM
• Quuxplusone accepted this revision.Apr 8 2021, 11:45 AM
This revision is now accepted and ready to land.Apr 8 2021, 11:45 AM
bruno accepted this revision.Apr 8 2021, 1:01 PM

LGTM

Closed by commit rG92498264269c: [clang] Tiny format fix (authored by urnathan). · Explain WhyApr 9 2021, 5:20 AM
This revision was automatically updated to reflect the committed changes.
urnathan added a commit: rG92498264269c: [clang] Tiny format fix.

Revision Contents

PathSize
clang/
lib/
Parse/
2 lines

Diff 336406

clang/lib/Parse/ParseDeclCXX.cpp

Show First 20 Lines • Show All 126 Lines • ▼ Show 20 Lines if (Tok.is(tok::equal)) {
} }
if (attrLoc.isValid()) if (attrLoc.isValid())
Diag(attrLoc, diag::err_unexpected_namespace_attributes_alias); Diag(attrLoc, diag::err_unexpected_namespace_attributes_alias);
if (InlineLoc.isValid()) if (InlineLoc.isValid())
Diag(InlineLoc, diag::err_inline_namespace_alias) Diag(InlineLoc, diag::err_inline_namespace_alias)
<< FixItHint::CreateRemoval(InlineLoc); << FixItHint::CreateRemoval(InlineLoc);
Decl *NSAlias = ParseNamespaceAlias(NamespaceLoc, IdentLoc, Ident, DeclEnd); Decl *NSAlias = ParseNamespaceAlias(NamespaceLoc, IdentLoc, Ident, DeclEnd);
return Actions.ConvertDeclToDeclGroup(NSAlias); return Actions.ConvertDeclToDeclGroup(NSAlias);
} }
BalancedDelimiterTracker T(*this, tok::l_brace); BalancedDelimiterTracker T(*this, tok::l_brace);
if (T.consumeOpen()) { if (T.consumeOpen()) {
if (Ident) if (Ident)
Diag(Tok, diag::err_expected) << tok::l_brace; Diag(Tok, diag::err_expected) << tok::l_brace;
else else
Diag(Tok, diag::err_expected_either) << tok::identifier << tok::l_brace; Diag(Tok, diag::err_expected_either) << tok::identifier << tok::l_brace;
return nullptr; return nullptr;
▲ Show 20 Lines • Show All 4,383 Lines • Show Last 20 Lines