Page MenuHomePhabricator

bruno (Bruno Cardoso Lopes)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 15 2014, 7:40 AM (329 w, 2 h)

Recent Activity

Wed, Dec 2

bruno accepted D92462: [Coroutines] Add DW_OP_deref for transformed dbg.value intrinsic..

Hmm... I'm using trunk lldb and gdb8.2, both of them can only print address. Btw, os is centos7.2, FYI.

Wed, Dec 2, 7:03 PM · Restricted Project
bruno added a comment to D92462: [Coroutines] Add DW_OP_deref for transformed dbg.value intrinsic..

Thanks for following up with this, I did miss to incorporate this suggestion! Out of curiosity, are you using lldb or gdb to print the variable? In lldb I already get values instead of address before this patch, so I wonder if one debugger needs more specific info than the other.

Wed, Dec 2, 9:28 AM · Restricted Project

Thu, Nov 19

bruno added inline comments to D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k.
Thu, Nov 19, 11:45 AM · Restricted Project
bruno added a comment to D88393: [cfe][M68k] (Patch 7/8) Basic Clang support.

Looking forward to see m68k support (and hopefully sega genesis toolchain support someday)!

Thu, Nov 19, 11:37 AM · Restricted Project

Wed, Nov 18

bruno added a comment to D86853: [modules] Fix crash in call to `FunctionDecl::setPure()`.

I forgot to follow up, but LGTM too.

Wed, Nov 18, 2:16 PM · Restricted Project

Tue, Nov 10

bruno committed rGdc14542a71f8: [Coroutines] Add missing llvm.dbg.declare's to cover for more allocas (authored by bruno).
[Coroutines] Add missing llvm.dbg.declare's to cover for more allocas
Tue, Nov 10, 12:36 PM
bruno closed D90772: [Coroutines] Add missing llvm.dbg.declare's to cover more allocas.
Tue, Nov 10, 12:36 PM · Restricted Project
bruno accepted D90990: [Coroutine][Sema] Cleanup temporaries as early as possible.

LGTM

Tue, Nov 10, 10:42 AM · Restricted Project
bruno added a comment to D90990: [Coroutine][Sema] Cleanup temporaries as early as possible.

Very nice explanation, thanks for improving this!

Tue, Nov 10, 12:48 AM · Restricted Project

Mon, Nov 9

bruno added a comment to D90772: [Coroutines] Add missing llvm.dbg.declare's to cover more allocas.

One of the another issue is that it is also necessary to track coroutine function parameters correctly under O1/O2 level which use dbg.value. Thoughts?

Mon, Nov 9, 6:18 PM · Restricted Project
bruno resigned from D49736: [Basic] Emit warning flag suggestion only in case there's existing flag *similar* to the unknown one.
Mon, Nov 9, 12:34 PM
bruno resigned from D45639: [Driver] Support default libc++ library location on Darwin.
Mon, Nov 9, 12:33 PM
bruno resigned from D41627: [Modules TS] Fix namespace visibility.
Mon, Nov 9, 12:33 PM
bruno resigned from D41566: [Modules TS] Diagnose exported internal linkage declarations.
Mon, Nov 9, 12:33 PM
bruno resigned from D41416: [modules] [pch] Do not deserialize all lazy template specializations when looking for one..
Mon, Nov 9, 12:32 PM
bruno resigned from D40443: [Modules TS] Make imports from an interface unit visible to its implementation units.
Mon, Nov 9, 12:32 PM
bruno resigned from D34985: Do not read the file to determine its name..
Mon, Nov 9, 12:28 PM
bruno resigned from D32111: [modules] Attempt to fix PR31905 - #include "stddef.h" breaks module map search paths; causes redefinitions..
Mon, Nov 9, 11:55 AM
bruno resigned from D27439: [libcxx][modules] Fix <stddef.h>'s module definition.
Mon, Nov 9, 11:55 AM
bruno resigned from D27396: Install the LLVM header module.modulemaps.
Mon, Nov 9, 11:55 AM
bruno resigned from D25337: [Modules] Add a command line option for enabling the modules feature exclusively for the Clang builtins..
Mon, Nov 9, 11:54 AM
bruno resigned from D24091: [Driver] Warn on -nodefaultlibs and -fsanitize.
Mon, Nov 9, 11:54 AM
bruno resigned from D19582: [X86] Add support for llvm.thread.pointer.
Mon, Nov 9, 11:52 AM
bruno resigned from D22638: Module: add debug_type to dump debugging messages related to modules being out of date.
Mon, Nov 9, 11:52 AM
bruno resigned from D23506: [RFC] Generate long nop instructions depending on function-specific subtarget info (version 2).
Mon, Nov 9, 11:52 AM
bruno resigned from D18898: [Loop Rotation] Make default max rotation header size threshold dependent on target CPU.
Mon, Nov 9, 11:30 AM
bruno added a comment to D90772: [Coroutines] Add missing llvm.dbg.declare's to cover more allocas.

Could you add a test (or update existing tests) to demonstrate that the issue is fixed?

Mon, Nov 9, 11:26 AM · Restricted Project
bruno accepted D91011: [NFC, Refactor] Rename the (scoped) enum DeclaratorContext's enumerators to avoid redundancy.

LGTM

Mon, Nov 9, 11:16 AM · Restricted Project

Fri, Nov 6

bruno updated the diff for D90772: [Coroutines] Add missing llvm.dbg.declare's to cover more allocas.

Update comments and now use dbg.values after @jmorse feedback.

Fri, Nov 6, 5:17 PM · Restricted Project
bruno added a comment to D90772: [Coroutines] Add missing llvm.dbg.declare's to cover more allocas.

Hi Jeremy,

Fri, Nov 6, 3:31 PM · Restricted Project
bruno added a comment to D90772: [Coroutines] Add missing llvm.dbg.declare's to cover more allocas.

This patch works for llvm.dbg.addr. So what is status of llvm.dbg.addr? does anyone know about it ?

Fri, Nov 6, 10:59 AM · Restricted Project

Thu, Nov 5

bruno abandoned D67010: [Modules] Move search paths from control block to unhashed control block.
Thu, Nov 5, 7:07 PM · Restricted Project
bruno abandoned D55676: [Modules] Fix decl order for DeclsInPrototype.
Thu, Nov 5, 7:05 PM
bruno abandoned D45012: [Modules] Skip adding unused module maps to the dependency file.
Thu, Nov 5, 7:04 PM
bruno abandoned D22474: [CodeGen] Suppress C++ static destructor registration.
Thu, Nov 5, 7:04 PM
bruno added a comment to D90772: [Coroutines] Add missing llvm.dbg.declare's to cover more allocas.

Hi Jeremy, thanks for taking a deep look here.

Thu, Nov 5, 6:56 PM · Restricted Project

Wed, Nov 4

bruno added inline comments to D90772: [Coroutines] Add missing llvm.dbg.declare's to cover more allocas.
Wed, Nov 4, 12:00 PM · Restricted Project
bruno requested review of D90772: [Coroutines] Add missing llvm.dbg.declare's to cover more allocas.
Wed, Nov 4, 10:00 AM · Restricted Project

Nov 2 2020

bruno added a comment to D88327: [SemaTemplateInstantiate] Handle lack of TypeSourceInfo on special member functions in templated lambdas.

@mdreseler Thanks for trying it out with other testcases, lemme take one more look and make it work for your c++14 version as well. @rsmith does the approach in this patch sounds reasonable?

Nov 2 2020, 10:29 AM

Oct 20 2020

bruno added a comment to D88327: [SemaTemplateInstantiate] Handle lack of TypeSourceInfo on special member functions in templated lambdas.

Ping.

Oct 20 2020, 1:35 PM

Oct 13 2020

bruno accepted D89361: [X86][NFC] Fix RUN line bug in the testcase.

LGTM

Oct 13 2020, 9:28 PM · Restricted Project

Oct 12 2020

bruno added a reviewer for D88327: [SemaTemplateInstantiate] Handle lack of TypeSourceInfo on special member functions in templated lambdas: erichkeane.
Oct 12 2020, 4:51 PM
bruno committed rGcffb0dd54d41: [SemaTemplate] Stop passing insertion position around during VarTemplate… (authored by bruno).
[SemaTemplate] Stop passing insertion position around during VarTemplate…
Oct 12 2020, 4:49 PM
bruno closed D87853: [SemaTemplate] Stop passing insertion position around during VarTemplate instantiation.
Oct 12 2020, 4:49 PM · Restricted Project
bruno added a comment to D88327: [SemaTemplateInstantiate] Handle lack of TypeSourceInfo on special member functions in templated lambdas.

Ping!

Oct 12 2020, 3:45 PM

Oct 8 2020

bruno accepted D78699: [X86] Passing union type through register..

LGTM

Oct 8 2020, 7:18 PM · Restricted Project

Oct 6 2020

bruno added a comment to D87853: [SemaTemplate] Stop passing insertion position around during VarTemplate instantiation.

Ping!

Oct 6 2020, 1:27 PM · Restricted Project
bruno added a comment to D88327: [SemaTemplateInstantiate] Handle lack of TypeSourceInfo on special member functions in templated lambdas.

Ping!

Oct 6 2020, 1:27 PM

Sep 28 2020

bruno added a comment to D87853: [SemaTemplate] Stop passing insertion position around during VarTemplate instantiation.

Ping!

Sep 28 2020, 2:26 PM · Restricted Project

Sep 25 2020

bruno updated the summary of D88327: [SemaTemplateInstantiate] Handle lack of TypeSourceInfo on special member functions in templated lambdas.
Sep 25 2020, 12:09 PM
bruno requested review of D88327: [SemaTemplateInstantiate] Handle lack of TypeSourceInfo on special member functions in templated lambdas.
Sep 25 2020, 11:47 AM
bruno added a comment to D78699: [X86] Passing union type through register..

Thanks, @bruno. Modifying the existing logic is risky. If we have to do that, I think a new patch will be better. The purpose of this patch is to solve an ABI bug.

Sep 25 2020, 10:49 AM · Restricted Project

Sep 22 2020

bruno added a comment to D78699: [X86] Passing union type through register..

Hi, @majnemer, @bruno. I saw that both of you have modified this logic. What's your opinion here?

Sep 22 2020, 1:38 PM · Restricted Project
bruno accepted D86895: [Modules] Add stats to measure performance of building and loading modules..

This looks pretty useful, thanks for adding this Volodymyr. LGTM.

Sep 22 2020, 10:46 AM · Restricted Project, Restricted Project, Restricted Project

Sep 21 2020

bruno updated the diff for D87853: [SemaTemplate] Stop passing insertion position around during VarTemplate instantiation.

Add context

Sep 21 2020, 11:52 PM · Restricted Project
bruno updated the diff for D87853: [SemaTemplate] Stop passing insertion position around during VarTemplate instantiation.

Hi Richard. Thanks for the quick feedback and for the testcase!

Sep 21 2020, 11:38 PM · Restricted Project
bruno commandeered D87853: [SemaTemplate] Stop passing insertion position around during VarTemplate instantiation.

I'm taking this over from Hongtao (w/ his blessing :)

Sep 21 2020, 11:34 PM · Restricted Project

Sep 1 2020

bruno added reviewers for D86853: [modules] Fix crash in call to `FunctionDecl::setPure()`: rsmith, v.g.vassilev.
Sep 1 2020, 11:42 AM · Restricted Project
bruno added inline comments to D86802: [Modules] Don't parse/load explicit module maps if modules are disabled.
Sep 1 2020, 10:51 AM · Restricted Project
bruno updated subscribers of D86896: [Modules] Add a small test suite to measure modules' performance..
Sep 1 2020, 10:28 AM · Restricted Project
bruno added a comment to D86896: [Modules] Add a small test suite to measure modules' performance..

Hi Volodymyr, this looks pretty interesting. Can you share screenshots or examples of how the output looks like?

Sep 1 2020, 10:26 AM · Restricted Project

Aug 31 2020

bruno added a comment to D82118: [clang][module] Improve incomplete-umbrella warning.

Yes the wrapper is definitely problematic. I'm checking how the diagnostic itself is handled correctly and start from there when I have time. For now would it be better to separate this into multiple patches and get the diagnostic improvement in first?

Aug 31 2020, 10:29 AM · Restricted Project

Aug 28 2020

bruno added inline comments to D86802: [Modules] Don't parse/load explicit module maps if modules are disabled.
Aug 28 2020, 12:58 PM · Restricted Project
bruno added a comment to D86802: [Modules] Don't parse/load explicit module maps if modules are disabled.

Hi Andrew, thanks for improving this. I think this makes sense: dependents can choose to not use modules without having to trigger the build system to rebuild all dependencies. Can you add a simple testcase to prove the point of the change?

Aug 28 2020, 12:24 PM · Restricted Project

Aug 18 2020

bruno added a comment to D85810: [clang] Pass-through remarks options to linker.

Hi Wei, this looks handy! Minor stylish comments below.

Aug 18 2020, 12:58 PM · Restricted Project
bruno accepted D80263: [HeaderSearch] Fix processing #import-ed headers multiple times with modules enabled..

Nice catch! LGTM

Aug 18 2020, 11:43 AM · Restricted Project
bruno accepted D80878: [clang] Prevent that Decl::dump on a CXXRecordDecl deserialises further declarations..

Neat unit test! LGTM (one minor suggestion below).

Aug 18 2020, 11:00 AM · Restricted Project
bruno added a comment to D82118: [clang][module] Improve incomplete-umbrella warning.

Hi Zixu, thanks for working on improving this.

Aug 18 2020, 10:51 AM · Restricted Project
bruno accepted D84458: [Modules] Improve error message when cannot find parent module for submodule definition..

LGTM as is, minor suggestion below.

Aug 18 2020, 10:25 AM · Restricted Project

Jul 14 2020

GitHub <noreply@github.com> committed rG47df64f64e5b: Merge pull request #1073 from bcardosolopes/apple-stable-20200108-x86-textual… (authored by bruno).
Merge pull request #1073 from bcardosolopes/apple-stable-20200108-x86-textual…
Jul 14 2020, 4:43 PM
bruno committed rGc5b600e0d508: [Modules] Add more x86 textual headers to the module map (authored by bruno).
[Modules] Add more x86 textual headers to the module map
Jul 14 2020, 4:43 PM
bruno committed rG915c19777ab4: [Modules] Reapply: Make header inclusion order from umbrella dirs deterministic (authored by bruno).
[Modules] Reapply: Make header inclusion order from umbrella dirs deterministic
Jul 14 2020, 4:34 PM
GitHub <noreply@github.com> committed rGdc2531c7537c: Merge pull request #925 from bcardosolopes/apple-stable-20200108-sort-umbrella… (authored by bruno).
Merge pull request #925 from bcardosolopes/apple-stable-20200108-sort-umbrella…
Jul 14 2020, 4:34 PM
GitHub <noreply@github.com> committed rGa8a4130d888b: Merge pull request #849 from bcardosolopes/apple-stable-20200108-odr-cc1-extra… (authored by bruno).
Merge pull request #849 from bcardosolopes/apple-stable-20200108-odr-cc1-extra…
Jul 14 2020, 4:30 PM
bruno committed rGfbe4d585a51f: [ODRHash] Add several `-cc1` options for fine grained odr checking control (authored by bruno).
[ODRHash] Add several `-cc1` options for fine grained odr checking control
Jul 14 2020, 4:29 PM
bruno committed rG9b3c79b06772: [PATCH] [ODRHash] Add basic support for hashing attributes (authored by bruno).
[PATCH] [ODRHash] Add basic support for hashing attributes
Jul 14 2020, 4:29 PM
GitHub <noreply@github.com> committed rGd82199c830d7: Merge pull request #848 from bcardosolopes/apple-stable-20200108-odr-hash… (authored by bruno).
Merge pull request #848 from bcardosolopes/apple-stable-20200108-odr-hash…
Jul 14 2020, 4:29 PM
bruno committed rG281a00fa0fbd: [ODRHash] Add tests for merging types for class extensions (authored by bruno).
[ODRHash] Add tests for merging types for class extensions
Jul 14 2020, 4:28 PM
GitHub <noreply@github.com> committed rG5af7e4e98743: Merge pull request #827 from bcardosolopes/apple-stable-20200108-odr-objc… (authored by bruno).
Merge pull request #827 from bcardosolopes/apple-stable-20200108-odr-objc…
Jul 14 2020, 4:28 PM
GitHub <noreply@github.com> committed rGf3aba2d9c5ef: Merge pull request #828 from bcardosolopes/apple-stable-20200108-odr-more… (authored by bruno).
Merge pull request #828 from bcardosolopes/apple-stable-20200108-odr-more…
Jul 14 2020, 4:28 PM
bruno committed rG4ceca22678dc: [ODRHash] Use more efficient storage for ODR hash in RecordDecl (authored by bruno).
[ODRHash] Use more efficient storage for ODR hash in RecordDecl
Jul 14 2020, 4:28 PM
GitHub <noreply@github.com> committed rGa23291837502: Merge pull request #829 from bcardosolopes/apple-stable-20200108-odr-merge… (authored by bruno).
Merge pull request #829 from bcardosolopes/apple-stable-20200108-odr-merge…
Jul 14 2020, 4:28 PM
bruno committed rGe4bb6d09a58c: [ODRHash] Change the approach to handle merging in absence of definitions (authored by bruno).
[ODRHash] Change the approach to handle merging in absence of definitions
Jul 14 2020, 4:28 PM
GitHub <noreply@github.com> committed rG4fb896257830: Merge pull request #825 from bcardosolopes/apple-stable-20200108-odr-objc… (authored by bruno).
Merge pull request #825 from bcardosolopes/apple-stable-20200108-odr-objc…
Jul 14 2020, 4:28 PM
bruno committed rG93169a318151: [PATCH 2/2] [Modules][ODRHash] Add support for merging ObjCCategoryDecl (authored by bruno).
[PATCH 2/2] [Modules][ODRHash] Add support for merging ObjCCategoryDecl
Jul 14 2020, 4:28 PM
bruno committed rGa79670c0f8ac: [PATCH 1/2] [ODRHash] ObjCInterface data merging: remove workaround to skip… (authored by bruno).
[PATCH 1/2] [ODRHash] ObjCInterface data merging: remove workaround to skip…
Jul 14 2020, 4:28 PM
GitHub <noreply@github.com> committed rGc2fcb08c022b: Merge pull request #798 from bcardosolopes/apple-stable-20200108-odr-objc… (authored by bruno).
Merge pull request #798 from bcardosolopes/apple-stable-20200108-odr-objc…
Jul 14 2020, 4:25 PM
bruno committed rG661447100e21: [ODRHash][APINotes] Prevent hashing OBJC_PR_null_resettable if from APINotes (authored by bruno).
[ODRHash][APINotes] Prevent hashing OBJC_PR_null_resettable if from APINotes
Jul 14 2020, 4:25 PM
GitHub <noreply@github.com> committed rG1e7da96039b3: Merge pull request #774 from bcardosolopes/apple-stable-20200108-odr-objc… (authored by bruno).
Merge pull request #774 from bcardosolopes/apple-stable-20200108-odr-objc…
Jul 14 2020, 4:23 PM
bruno committed rG7ab779297169: Use desugared type for ObjCProperty with nullable types (authored by bruno).
Use desugared type for ObjCProperty with nullable types
Jul 14 2020, 4:23 PM
GitHub <noreply@github.com> committed rGfa2348cb7738: Merge pull request #755 from bcardosolopes/apple-stable-20200108-odr-objc… (authored by bruno).
Merge pull request #755 from bcardosolopes/apple-stable-20200108-odr-objc…
Jul 14 2020, 4:22 PM
bruno committed rG74b87a0e8565: [ODRHash] Check references protocols as part of MergeDefintionData (authored by bruno).
[ODRHash] Check references protocols as part of MergeDefintionData
Jul 14 2020, 4:22 PM
GitHub <noreply@github.com> committed rG28a6983d3535: Merge pull request #724 from bcardosolopes/apple-stable-20200108-odr-objc… (authored by bruno).
Merge pull request #724 from bcardosolopes/apple-stable-20200108-odr-objc…
Jul 14 2020, 4:20 PM
bruno committed rG9cc6f4745141: [Modules][ODRHash] Add diagnostics for property implementation control mismatch (authored by bruno).
[Modules][ODRHash] Add diagnostics for property implementation control mismatch
Jul 14 2020, 4:20 PM
GitHub <noreply@github.com> committed rG120dbe8f28ee: Merge pull request #719 from bcardosolopes/apple-stable-20200108-odr-objc… (authored by bruno).
Merge pull request #719 from bcardosolopes/apple-stable-20200108-odr-objc…
Jul 14 2020, 4:20 PM
bruno committed rGa39404e1fdbf: [PATCH 3/3] [Modules][ODRHash] Add ODR checking for @protocols (authored by bruno).
[PATCH 3/3] [Modules][ODRHash] Add ODR checking for @protocols
Jul 14 2020, 4:20 PM
bruno committed rG15289bb26121: [PATCH 2/3] [ODRHash] Factor out protocol list checking from interface ODR… (authored by bruno).
[PATCH 2/3] [ODRHash] Factor out protocol list checking from interface ODR…
Jul 14 2020, 4:20 PM
bruno committed rG63e4fe0c0b78: [PATCH 1/3] [ODRHash] Change signature for ODRDiagDeclError and make it… (authored by bruno).
[PATCH 1/3] [ODRHash] Change signature for ODRDiagDeclError and make it…
Jul 14 2020, 4:20 PM
GitHub <noreply@github.com> committed rGab18ceb63dfd: Merge pull request #708 from bcardosolopes/apple-stable-20200108-odr-objc… (authored by bruno).
Merge pull request #708 from bcardosolopes/apple-stable-20200108-odr-objc…
Jul 14 2020, 4:19 PM
bruno committed rG6dd0ccf4ba53: [PATCH 2/2] [Modules][ODRHash] Add ODRHash support for ObjCProperty (authored by bruno).
[PATCH 2/2] [Modules][ODRHash] Add ODRHash support for ObjCProperty
Jul 14 2020, 4:19 PM