Page MenuHomePhabricator

bruno (Bruno Cardoso Lopes)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 15 2014, 7:40 AM (357 w, 3 d)

Recent Activity

Yesterday

bruno added a comment to D88327: [SemaTemplateInstantiate] Handle lack of TypeSourceInfo on special member functions in templated lambdas.

Ping

Mon, Jun 21, 12:26 PM

Fri, Jun 18

bruno added inline comments to D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode.
Fri, Jun 18, 12:27 PM · Restricted Project

Thu, Jun 17

bruno added a comment to D103930: [clang][HeaderSearch] Fix implicit module when using header maps.

@dexonsmith and @jansvoboda11 thanks for the fast reply and the extra testing.

Thu, Jun 17, 2:33 PM · Restricted Project

Tue, Jun 15

bruno accepted D102820: [Clang] Check for returns_nonnull when deciding to add allocation null checks.

Assuming I'm answering the correct question that the returns_nonnull is preserved through a PCH, the answer is yes.

Tue, Jun 15, 4:55 PM · Restricted Project
bruno updated subscribers of D103930: [clang][HeaderSearch] Fix implicit module when using header maps.

Thanks for working on this, comments inline. @vsapsai @jansvoboda11 @dexonsmith any headermap related concerns on your side?

Tue, Jun 15, 4:42 PM · Restricted Project
bruno added a comment to D88327: [SemaTemplateInstantiate] Handle lack of TypeSourceInfo on special member functions in templated lambdas.

Ping

Tue, Jun 15, 3:32 PM

Mon, Jun 7

bruno added a comment to D88327: [SemaTemplateInstantiate] Handle lack of TypeSourceInfo on special member functions in templated lambdas.

Ping

Mon, Jun 7, 12:45 PM

Fri, Jun 4

bruno accepted D103722: [clang] NFC: test for undefined behaviour in RawComment::getFormattedText().

Thanks for adding more tests! LGTM.

Fri, Jun 4, 3:34 PM · Restricted Project

Wed, Jun 2

bruno accepted D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics.

LGTM!

Wed, Jun 2, 9:31 AM · Restricted Project

Tue, Jun 1

bruno added inline comments to D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics.
Tue, Jun 1, 1:01 PM · Restricted Project
bruno accepted D103258: [clang] Fix ICE with typeid & polymorphic class (pr50497).

LGTM

Tue, Jun 1, 12:36 PM · Restricted Project
bruno added a comment to D88327: [SemaTemplateInstantiate] Handle lack of TypeSourceInfo on special member functions in templated lambdas.

Ping.

Tue, Jun 1, 11:20 AM
bruno added a comment to D98995: [CGAtomic] Lift stronger requirements on cmpxch and add support for acquire failure mode.

@yln sorry, I didn't get notifications for this somehow. This got fixed as part of the more general support in https://github.com/llvm/llvm-project/commit/819e0d105e84c6081cfcfa0e38fd257b6124553a

Tue, Jun 1, 10:18 AM · Restricted Project, Restricted Project

Thu, May 27

bruno requested changes to D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics.

Overall looks good, few remaining nitpicks.

Thu, May 27, 5:32 PM · Restricted Project
bruno accepted D103229: [clang] NFC: split HeaderMapTest to have re-usable header map implementation for testing.

LGTM

Thu, May 27, 12:35 PM · Restricted Project

Wed, May 26

bruno updated subscribers of D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics.
Wed, May 26, 5:38 PM · Restricted Project

Tue, May 25

bruno committed rG6c35991ca024: [TSAN][CMake] Add support to run lit on individual tests (authored by bruno).
[TSAN][CMake] Add support to run lit on individual tests
Tue, May 25, 12:33 PM
bruno closed D103054: [TSAN][CMake] Add support to run lit on individual tests.
Tue, May 25, 12:33 PM · Restricted Project

Mon, May 24

bruno requested review of D103054: [TSAN][CMake] Add support to run lit on individual tests.
Mon, May 24, 3:56 PM · Restricted Project

May 21 2021

bruno accepted D100276: [clang] p1099 3/5: using Enum::member.

LGTM. An additional review here would be nice though.

May 21 2021, 1:26 PM · Restricted Project

May 20 2021

bruno accepted D102241: [clang] p1099 4/5: using enum EnumTag.

Thanks for adding the tests. LGTM after some remaining nitpick.

May 20 2021, 6:12 PM · Restricted Project, Restricted Project
bruno resigned from D53522: [Frontend] Include module map header declaration in dependency file output.
May 20 2021, 5:59 PM
bruno updated the diff for D88327: [SemaTemplateInstantiate] Handle lack of TypeSourceInfo on special member functions in templated lambdas.

Update after last round of reviews.

May 20 2021, 3:00 PM
bruno added a comment to D88327: [SemaTemplateInstantiate] Handle lack of TypeSourceInfo on special member functions in templated lambdas.

Nothing else of substance from me, but I don't feel confident in giving final sign off on this. LG, but please wait until one of the other reviewers accepts as well.

May 20 2021, 2:54 PM
bruno added a comment to D102782: Add support for Warning Flag "-Wstack-usage=".

Overall looks good, sounds like it's failing tests though?

May 20 2021, 2:45 PM · Restricted Project
bruno resigned from D101965: Added Support for Warning Flag -Wstack-usage=.
May 20 2021, 2:44 PM · Restricted Project, Restricted Project
bruno resigned from D101964: Added support for -Wstack-usage flag and Framesize reporting fix.
May 20 2021, 2:44 PM · Restricted Project, Restricted Project
bruno accepted D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl.

LGTM

May 20 2021, 2:34 PM · Restricted Project, Restricted Project
bruno added a comment to D102820: [Clang] Check for returns_nonnull when deciding to add allocation null checks.

Sounds reasonable to me! Can you double check whether this attribute gets correctly serialized/deserialized in face of CXXNewExpr? An example of how to test that would be in clang/test/PCH/cxx-method.cpp.

May 20 2021, 2:19 PM · Restricted Project

May 19 2021

bruno resigned from D80172: Revert "Re-fix _lrotl/_lrotr to always take Long, no matter the platform.".
May 19 2021, 6:14 PM · Restricted Project
bruno resigned from D78058: option to write files to memory instead of disk.
May 19 2021, 6:14 PM · Restricted Project
bruno resigned from D70563: Use kevent queue for detecting file unlocking in LockFileManager.
May 19 2021, 6:13 PM · Restricted Project, Restricted Project
bruno resigned from D66172: [clang][Modules] Serialize decl to comment mapping to speed up code completion..
May 19 2021, 6:12 PM
bruno resigned from D60356: Accelerate isPotentiallyReachable when a DominatorTree is available..
May 19 2021, 6:12 PM · Restricted Project
bruno resigned from D54880: Ignore gcc's stack-clash-protection flag.
May 19 2021, 6:10 PM · Restricted Project

May 18 2021

bruno updated the diff for D88327: [SemaTemplateInstantiate] Handle lack of TypeSourceInfo on special member functions in templated lambdas.

Update patch after @aaron.ballman review!

May 18 2021, 6:01 PM
bruno added a comment to D88327: [SemaTemplateInstantiate] Handle lack of TypeSourceInfo on special member functions in templated lambdas.

Thanks for the review @aaron.ballman!

May 18 2021, 5:57 PM

May 17 2021

bruno updated the diff for D88327: [SemaTemplateInstantiate] Handle lack of TypeSourceInfo on special member functions in templated lambdas.

Make this work for c++14 as well, update testcase to cover all possibilities mentioned. @mdreseler thanks for bringing this up.

May 17 2021, 6:01 PM

May 14 2021

bruno accepted D102239: [clang][NFC] p1099 2/5: Break out enum completion from context completion.

Looks good to me with the remaining clang-format linting on the assert.

May 14 2021, 10:30 AM · Restricted Project

May 13 2021

bruno added inline comments to D102241: [clang] p1099 4/5: using enum EnumTag.
May 13 2021, 11:23 PM · Restricted Project, Restricted Project
bruno added a comment to D100276: [clang] p1099 3/5: using Enum::member.

Overall looks good, one more comment below.

May 13 2021, 11:18 PM · Restricted Project
bruno added inline comments to D102239: [clang][NFC] p1099 2/5: Break out enum completion from context completion.
May 13 2021, 11:03 PM · Restricted Project
bruno added a comment to D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl.

You should also update the title with [NFC] or similar.

May 13 2021, 10:43 PM · Restricted Project, Restricted Project
bruno added a comment to D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl.

The approach looks good. There are some test failures - you need to update some bits in clangd and probably anywhere else in the repo that you see uses of getUsingDecl().

May 13 2021, 10:41 PM · Restricted Project, Restricted Project
bruno committed rGfd184c062c1a: [TSAN] Honor failure memory orders in AtomicCAS (authored by bruno).
[TSAN] Honor failure memory orders in AtomicCAS
May 13 2021, 1:08 AM
bruno closed D99434: [TSAN] Honor failure memory orders in AtomicCAS.
May 13 2021, 1:07 AM · Restricted Project, Restricted Project
bruno added inline comments to D99434: [TSAN] Honor failure memory orders in AtomicCAS.
May 13 2021, 12:20 AM · Restricted Project, Restricted Project

May 12 2021

bruno updated the diff for D99434: [TSAN] Honor failure memory orders in AtomicCAS.

Update patch to reduce code dup as suggested by @dvyukov

May 12 2021, 2:25 PM · Restricted Project, Restricted Project
bruno added inline comments to D99434: [TSAN] Honor failure memory orders in AtomicCAS.
May 12 2021, 2:23 PM · Restricted Project, Restricted Project

May 11 2021

bruno updated the diff for D99434: [TSAN] Honor failure memory orders in AtomicCAS.

Cool, thanks for the input!

May 11 2021, 5:43 PM · Restricted Project, Restricted Project

May 10 2021

bruno updated the diff for D99434: [TSAN] Honor failure memory orders in AtomicCAS.

Thank you @dvyukov for another round of reviews! A have more questions for you.

May 10 2021, 1:20 PM · Restricted Project, Restricted Project

May 6 2021

bruno updated the diff for D99434: [TSAN] Honor failure memory orders in AtomicCAS.

Cover more cases in atomic.ll.

May 6 2021, 10:50 PM · Restricted Project, Restricted Project
bruno updated the diff for D99434: [TSAN] Honor failure memory orders in AtomicCAS.

Apply more reviewer suggested changes: first evaluate CAS, then decide what order to use.

May 6 2021, 10:38 PM · Restricted Project, Restricted Project
bruno closed D101501: [CGAtomic] Lyft strong requirement for remaining compare_exchange combinations.

Forgot to add the Differential tag, my bad. Closed by https://reviews.llvm.org/rG819e0d105e84

May 6 2021, 9:28 PM · Restricted Project
bruno committed rG819e0d105e84: [CGAtomic] Lift strong requirement for remaining compare_exchange combinations (authored by bruno).
[CGAtomic] Lift strong requirement for remaining compare_exchange combinations
May 6 2021, 9:09 PM
bruno added a comment to D101501: [CGAtomic] Lyft strong requirement for remaining compare_exchange combinations.

LGTM, except that the commit message should say "Lift", not "Lyft". ;)

May 6 2021, 9:00 PM · Restricted Project
bruno updated the diff for D101501: [CGAtomic] Lyft strong requirement for remaining compare_exchange combinations.

Reduce the diff in a test.

May 6 2021, 7:25 PM · Restricted Project
bruno updated the diff for D101501: [CGAtomic] Lyft strong requirement for remaining compare_exchange combinations.

Update after @rjmccall comments!

May 6 2021, 7:20 PM · Restricted Project

May 4 2021

bruno added a comment to D101501: [CGAtomic] Lyft strong requirement for remaining compare_exchange combinations.

Don't mind JF, he's just forgotten that C++ lacks the ability to turn the typically constant value arguments passed to functions like std::atomic::compare_exchange_strong into actual compile-time constants to the builtin used within those functions, so his advice would mean emitting all atomics in C++ as sequentially consistent.

May 4 2021, 4:23 PM · Restricted Project

May 3 2021

bruno added inline comments to D101501: [CGAtomic] Lyft strong requirement for remaining compare_exchange combinations.
May 3 2021, 7:08 PM · Restricted Project
bruno updated the diff for D99434: [TSAN] Honor failure memory orders in AtomicCAS.

Update broken comment in the testcase.

May 3 2021, 3:15 PM · Restricted Project, Restricted Project
bruno updated the diff for D101501: [CGAtomic] Lyft strong requirement for remaining compare_exchange combinations.

Fix failing tests and clang-format issue.

May 3 2021, 3:10 PM · Restricted Project
bruno added inline comments to D99434: [TSAN] Honor failure memory orders in AtomicCAS.
May 3 2021, 3:08 PM · Restricted Project, Restricted Project
bruno updated the diff for D99434: [TSAN] Honor failure memory orders in AtomicCAS.

Apply review comments.

May 3 2021, 3:08 PM · Restricted Project, Restricted Project

Apr 29 2021

bruno accepted D101530: clang: Update comments on another libstdc++ HACK.

Thanks for keeping a good track of these hacks. Nitpick: before landing, use single instead of double spaces before a new sentence in the comments. LGTM.

Apr 29 2021, 3:28 PM · Restricted Project
bruno accepted D100914: [clang] Revert "Re-fix _lrotl/_lrotr to always take Long, no matter the platform.".

This is the same as https://reviews.llvm.org/D80172, right? LGTM.

Apr 29 2021, 3:21 PM · Restricted Project

Apr 28 2021

bruno added inline comments to D99434: [TSAN] Honor failure memory orders in AtomicCAS.
Apr 28 2021, 5:16 PM · Restricted Project, Restricted Project
bruno updated the diff for D99434: [TSAN] Honor failure memory orders in AtomicCAS.

Address reviewer comments. To prevent false positive on release/consume, this now depends on https://reviews.llvm.org/D101501.

Apr 28 2021, 5:11 PM · Restricted Project, Restricted Project
bruno requested review of D101501: [CGAtomic] Lyft strong requirement for remaining compare_exchange combinations.
Apr 28 2021, 5:09 PM · Restricted Project
bruno accepted D101441: Update libstdc++ hack comment.

LGTM

Apr 28 2021, 9:54 AM · Restricted Project

Apr 20 2021

bruno added a comment to D100276: [clang] p1099 3/5: using Enum::member.

Hi Nathan, thanks for implementing this. Besides formatting nitpicks, few other comments/questions:

Apr 20 2021, 4:56 PM · Restricted Project

Apr 8 2021

bruno accepted D100129: Tiny format fix.

LGTM

Apr 8 2021, 1:01 PM · Restricted Project

Apr 6 2021

bruno added a comment to D99434: [TSAN] Honor failure memory orders in AtomicCAS.

Thanks both of you for the review @delcypher and @yln, will wait for @dvyukov to sign-off!

Apr 6 2021, 5:33 PM · Restricted Project, Restricted Project

Apr 5 2021

bruno added a reviewer for D99434: [TSAN] Honor failure memory orders in AtomicCAS: yln.
Apr 5 2021, 12:09 PM · Restricted Project, Restricted Project
bruno added reviewers for D99434: [TSAN] Honor failure memory orders in AtomicCAS: delcypher, vitalybuka.
Apr 5 2021, 12:08 PM · Restricted Project, Restricted Project

Apr 1 2021

bruno added a comment to D99434: [TSAN] Honor failure memory orders in AtomicCAS.

Ping.

Apr 1 2021, 2:48 PM · Restricted Project, Restricted Project

Mar 26 2021

bruno requested review of D99434: [TSAN] Honor failure memory orders in AtomicCAS.
Mar 26 2021, 12:12 PM · Restricted Project, Restricted Project

Mar 23 2021

bruno committed rG431e3138a1f3: [CGAtomic] Lift stronger requirements on cmpxch and support acquire failure mode (authored by bruno).
[CGAtomic] Lift stronger requirements on cmpxch and support acquire failure mode
Mar 23 2021, 4:46 PM
bruno closed D98995: [CGAtomic] Lift stronger requirements on cmpxch and add support for acquire failure mode.
Mar 23 2021, 4:45 PM · Restricted Project, Restricted Project
bruno updated the diff for D98995: [CGAtomic] Lift stronger requirements on cmpxch and add support for acquire failure mode.

@jfb sure!

Mar 23 2021, 4:44 PM · Restricted Project, Restricted Project

Mar 19 2021

bruno updated subscribers of D98995: [CGAtomic] Lift stronger requirements on cmpxch and add support for acquire failure mode.
Mar 19 2021, 5:35 PM · Restricted Project, Restricted Project
bruno requested review of D98995: [CGAtomic] Lift stronger requirements on cmpxch and add support for acquire failure mode.
Mar 19 2021, 5:31 PM · Restricted Project, Restricted Project

Mar 17 2021

bruno added a comment to D98638: [RFC][Coroutine] Force stack allocation after await_suspend() call.

Hi Xun, great to see more improvements in this area.

Mar 17 2021, 9:08 PM · Restricted Project, Restricted Project

Jan 26 2021

bruno added a comment to D93497: Salvage debug info for function arguments in coro-split funclets..

If you have any testcases that would make sense to add to the LLDB testsuite, let me know! It will make it harder for me to break C++ coroutines as I'm working on Swift coroutine support.

Jan 26 2021, 3:04 PM · Restricted Project
bruno accepted D93497: Salvage debug info for function arguments in coro-split funclets..

Awesome. I've also tested the last version of the patch against some testcases I care about and they all debug fine under lldb!

Jan 26 2021, 2:07 PM · Restricted Project

Jan 25 2021

bruno added a comment to D93497: Salvage debug info for function arguments in coro-split funclets..

Hi Adrian, this is nice, I really like the approach! Do you think that this supersedes https://reviews.llvm.org/D90772? I'm curious if we can stop generating the extra dbg.values inserted, or whether those are necessary for your reconstruction work?

Jan 25 2021, 11:28 PM · Restricted Project

Jan 15 2021

bruno added a reviewer for D94834: [Coroutine] Do not CoroElide if there are musttail calls: bruno.

Nice correctness improvement!

Jan 15 2021, 5:17 PM · Restricted Project

Jan 12 2021

bruno added a comment to D94388: [Coroutine][DebugInfo] Enhance the ability of coroutine to debug parameters under O2.

Hi Yifeng,

Jan 12 2021, 11:51 AM · Restricted Project

Dec 9 2020

bruno accepted D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k.

LGTM, it would be great if someone else stamps this too, in case I missed something.

Dec 9 2020, 11:01 PM · Restricted Project

Dec 4 2020

bruno accepted D88393: [cfe][M68k] (Patch 7/8) Basic Clang support.

LGTM

Dec 4 2020, 2:24 PM · Restricted Project
bruno added a reviewer for D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k: bruno.
Dec 4 2020, 2:18 PM · Restricted Project

Dec 2 2020

bruno accepted D92462: [Coroutines] Add DW_OP_deref for transformed dbg.value intrinsic..

Hmm... I'm using trunk lldb and gdb8.2, both of them can only print address. Btw, os is centos7.2, FYI.

Dec 2 2020, 7:03 PM · Restricted Project
bruno added a comment to D92462: [Coroutines] Add DW_OP_deref for transformed dbg.value intrinsic..

Thanks for following up with this, I did miss to incorporate this suggestion! Out of curiosity, are you using lldb or gdb to print the variable? In lldb I already get values instead of address before this patch, so I wonder if one debugger needs more specific info than the other.

Dec 2 2020, 9:28 AM · Restricted Project

Nov 19 2020

bruno added inline comments to D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k.
Nov 19 2020, 11:45 AM · Restricted Project
bruno added a comment to D88393: [cfe][M68k] (Patch 7/8) Basic Clang support.

Looking forward to see m68k support (and hopefully sega genesis toolchain support someday)!

Nov 19 2020, 11:37 AM · Restricted Project

Nov 18 2020

bruno added a comment to D86853: [modules] Fix crash in call to `FunctionDecl::setPure()`.

I forgot to follow up, but LGTM too.

Nov 18 2020, 2:16 PM · Restricted Project

Nov 10 2020

bruno committed rGdc14542a71f8: [Coroutines] Add missing llvm.dbg.declare's to cover for more allocas (authored by bruno).
[Coroutines] Add missing llvm.dbg.declare's to cover for more allocas
Nov 10 2020, 12:36 PM
bruno closed D90772: [Coroutines] Add missing llvm.dbg.declare's to cover more allocas.
Nov 10 2020, 12:36 PM · Restricted Project
bruno accepted D90990: [Coroutine][Sema] Cleanup temporaries as early as possible.

LGTM

Nov 10 2020, 10:42 AM · Restricted Project
bruno added a comment to D90990: [Coroutine][Sema] Cleanup temporaries as early as possible.

Very nice explanation, thanks for improving this!

Nov 10 2020, 12:48 AM · Restricted Project