Skip to content

Commit 33291e4

Browse files
committedSep 28, 2018
[ARM] Remove non-existent cpu arm1176j-s and use mpcore for v6k
The ARMTargetParser.def contains an entry for arm1176j-s which is the default for the ArmV6K architecture. This cpu does not exist, there are only arm1176jz-s and arm1176jzf-s and they are both architecture ArmV6KZ. The only CPUs that are actually ArmV6K are the mpcore, mpcore_nofpu and later revisions of the arm1136 family r1px (which we don't have a table entry for). This patch removes the arm1176j-s and makes mpcore the default for armv6k. Differential Revision: https://reviews.llvm.org/D52594 llvm-svn: 343303
1 parent ea60591 commit 33291e4

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed
 

Diff for: ‎llvm/include/llvm/Support/ARMTargetParser.def

+2-3
Original file line numberDiff line numberDiff line change
@@ -208,10 +208,9 @@ ARM_CPU_NAME("arm926ej-s", ARMV5TEJ, FK_NONE, true, ARM::AEK_NONE)
208208
ARM_CPU_NAME("arm1136j-s", ARMV6, FK_NONE, false, ARM::AEK_NONE)
209209
ARM_CPU_NAME("arm1136jf-s", ARMV6, FK_VFPV2, true, ARM::AEK_NONE)
210210
ARM_CPU_NAME("arm1136jz-s", ARMV6, FK_NONE, false, ARM::AEK_NONE)
211-
ARM_CPU_NAME("arm1176j-s", ARMV6K, FK_NONE, true, ARM::AEK_NONE)
212-
ARM_CPU_NAME("arm1176jz-s", ARMV6KZ, FK_NONE, false, ARM::AEK_NONE)
213-
ARM_CPU_NAME("mpcore", ARMV6K, FK_VFPV2, false, ARM::AEK_NONE)
211+
ARM_CPU_NAME("mpcore", ARMV6K, FK_VFPV2, true, ARM::AEK_NONE)
214212
ARM_CPU_NAME("mpcorenovfp", ARMV6K, FK_NONE, false, ARM::AEK_NONE)
213+
ARM_CPU_NAME("arm1176jz-s", ARMV6KZ, FK_NONE, false, ARM::AEK_NONE)
215214
ARM_CPU_NAME("arm1176jzf-s", ARMV6KZ, FK_VFPV2, true, ARM::AEK_NONE)
216215
ARM_CPU_NAME("arm1156t2-s", ARMV6T2, FK_NONE, true, ARM::AEK_NONE)
217216
ARM_CPU_NAME("arm1156t2f-s", ARMV6T2, FK_VFPV2, false, ARM::AEK_NONE)

Diff for: ‎llvm/unittests/Support/TargetParserTest.cpp

+2-4
Original file line numberDiff line numberDiff line change
@@ -126,8 +126,6 @@ TEST(TargetParserTest, testARMCPU) {
126126
ARM::AEK_DSP, "6"));
127127
EXPECT_TRUE(testARMCPU("arm1136jz-s", "armv6", "none",
128128
ARM::AEK_DSP, "6"));
129-
EXPECT_TRUE(testARMCPU("arm1176j-s", "armv6k", "none",
130-
ARM::AEK_DSP, "6K"));
131129
EXPECT_TRUE(testARMCPU("arm1176jz-s", "armv6kz", "none",
132130
ARM::AEK_SEC | ARM::AEK_DSP, "6KZ"));
133131
EXPECT_TRUE(testARMCPU("mpcore", "armv6k", "vfpv2",
@@ -285,7 +283,7 @@ TEST(TargetParserTest, testARMCPU) {
285283
"7-S"));
286284
}
287285

288-
static constexpr unsigned NumARMCPUArchs = 83;
286+
static constexpr unsigned NumARMCPUArchs = 82;
289287

290288
TEST(TargetParserTest, testARMCPUArchList) {
291289
SmallVector<StringRef, NumARMCPUArchs> List;
@@ -346,7 +344,7 @@ TEST(TargetParserTest, testARMArch) {
346344
testARMArch("armv6", "arm1136jf-s", "v6",
347345
ARMBuildAttrs::CPUArch::v6));
348346
EXPECT_TRUE(
349-
testARMArch("armv6k", "arm1176j-s", "v6k",
347+
testARMArch("armv6k", "mpcore", "v6k",
350348
ARMBuildAttrs::CPUArch::v6K));
351349
EXPECT_TRUE(
352350
testARMArch("armv6t2", "arm1156t2-s", "v6t2",

0 commit comments

Comments
 (0)
Please sign in to comment.