This is an archive of the discontinued LLVM Phabricator instance.

[PlaceSafepoints] Switch to being a FunctionPass
ClosedPublic

Authored by reames on May 7 2015, 5:03 PM.

Details

Summary

The pass doesn't actually modify the module outside of the function being processed. The only confusing piece is that it both inserts calls and then inlines the resulting calls. Given that, it definitely invalidates module level analysis results, but many FunctionPasses do that.

Diff Detail

Event Timeline

reames updated this revision to Diff 25264.May 7 2015, 5:03 PM
reames retitled this revision from to [PlaceSafepoints] Switch to being a FunctionPass.
reames updated this object.
reames edited the test plan for this revision. (Show Details)
reames added a reviewer: sanjoy.
reames added a subscriber: Unknown Object (MLST).
sanjoy accepted this revision.May 8 2015, 1:15 AM
sanjoy edited edge metadata.
This revision is now accepted and ready to land.May 8 2015, 1:15 AM
This revision was automatically updated to reflect the committed changes.