This is an archive of the discontinued LLVM Phabricator instance.

Sparc assembler should accept parenthesized constant expressions.
ClosedPublic

Authored by dougk on Apr 17 2015, 1:01 PM.

Download Raw Diff

Details

Reviewers

Commits

rG9cb88b73c69f: Make Sparc assembler accept parenthesized constant expressions.
rL236137: Make Sparc assembler accept parenthesized constant expressions.

Diff Detail

Event Timeline

dougk updated this revision to Diff 23959.Apr 17 2015, 1:01 PM

dougk retitled this revision from to Sparc assembler should accept parenthesized constant expressions..

dougk updated this object.

dougk edited the test plan for this revision. (Show Details)

dougk added a subscriber: Unknown Object (MLST).

Code change is OK.

You are probably the one that knows the most about Sparc, so leaving to you to check that this matches what gas does.

This revision is now accepted and ready to land.Apr 20 2015, 5:27 PM

Closed by commit rL236137: Make Sparc assembler accept parenthesized constant expressions. (authored by dougk). · Explain WhyApr 29 2015, 11:51 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

lib/

Target/

Sparc/

AsmParser/

SparcAsmParser.cpp

1 line

test/

MC/

Sparc/

sparc-assembly-exprs.s

6 lines

Diff 23959

lib/Target/Sparc/AsmParser/SparcAsmParser.cpp

Show First 20 Lines • Show All 676 Lines • ▼ Show 20 Lines	case AsmToken::Percent:
if (matchSparcAsmModifiers(EVal, E)) {		if (matchSparcAsmModifiers(EVal, E)) {
E = SMLoc::getFromPointer(Parser.getTok().getLoc().getPointer() - 1);		E = SMLoc::getFromPointer(Parser.getTok().getLoc().getPointer() - 1);
Op = SparcOperand::CreateImm(EVal, S, E);		Op = SparcOperand::CreateImm(EVal, S, E);
}		}
break;		break;

case AsmToken::Minus:		case AsmToken::Minus:
case AsmToken::Integer:		case AsmToken::Integer:
		case AsmToken::LParen:
if (!getParser().parseExpression(EVal, E))		if (!getParser().parseExpression(EVal, E))
Op = SparcOperand::CreateImm(EVal, S, E);		Op = SparcOperand::CreateImm(EVal, S, E);
break;		break;

case AsmToken::Identifier: {		case AsmToken::Identifier: {
StringRef Identifier;		StringRef Identifier;
if (!getParser().parseIdentifier(Identifier)) {		if (!getParser().parseIdentifier(Identifier)) {
E = SMLoc::getFromPointer(Parser.getTok().getLoc().getPointer() - 1);		E = SMLoc::getFromPointer(Parser.getTok().getLoc().getPointer() - 1);
▲ Show 20 Lines • Show All 244 Lines • Show Last 20 Lines

test/MC/Sparc/sparc-assembly-exprs.s

This file was added.

				! RUN: llvm-mc %s -arch=sparc -show-encoding \| FileCheck %s

				! CHECK: mov 1033, %o1 ! encoding: [0x92,0x10,0x24,0x09]
				mov (0x400\|9), %o1
				! CHECK: mov 60, %o2 ! encoding: [0x94,0x10,0x20,0x3c]
				mov (12+3<<2), %o2