Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D78111

tsan: fixes to ThreadClock::releaseStoreAcquire
ClosedPublic
Actions

Authored by dfava on Apr 14 2020, 8:13 AM.

Details

Reviewers
dvyukov
Summary

Fixes:

  1. Setting the number of entries in a thread's clock to max between the thread and the SyncClock the thread is acquiring from
  2. Setting last_acquire_

Unit- and stress-test for releaseStoreAcquire added to tests/unit/tsan_clock_test.cpp

Diff Detail

Event Timeline

dfava created this revision.Apr 14 2020, 8:13 AM
dvyukov added a comment.Apr 14 2020, 10:01 AM

Please add a unit test for these bugs to tsan/tests/unit/tsan_clock_test.cpp and releaseStoreAcquire to the stress test in that file.

dfava updated this revision to Diff 257747.Apr 15 2020, 9:10 AM
dfava edited the summary of this revision. (Show Details)
dvyukov accepted this revision.Apr 16 2020, 2:22 AM

You can now land this yourself, right?

This revision is now accepted and ready to land.Apr 16 2020, 2:22 AM
dfava added a comment.Apr 16 2020, 1:58 PM

Committed in https://github.com/llvm/llvm-project/commit/3b222ef246ef9298e57d00b7c8c1ffd92d0fb44d

dfava closed this revision.Apr 16 2020, 2:01 PM

Revision Contents
Changeset List

PathSize
compiler-rt/
lib/
tsan/
rtl/
17 lines
tests/
unit/
45 lines

Diff 257747

View Options

compiler-rt/lib/tsan/rtl/tsan_clock.cpp

Loading...
View Options

compiler-rt/lib/tsan/tests/unit/tsan_clock_test.cpp

Loading...