Page MenuHomePhabricator

Update comments to use unreachable instead of llvm.trap, as implemented now
ClosedPublic

Authored by rnk on Jan 29 2015, 2:24 PM.

Details

Summary

win64: Call __chkstk through a register with the large code model

Fixes half of PR18582. True dynamic allocas will still have a
CALL64pcrel32 which will fail.

Diff Detail

Repository
rL LLVM

Event Timeline

rnk updated this revision to Diff 18988.Jan 29 2015, 2:24 PM
rnk retitled this revision from to Update comments to use unreachable instead of llvm.trap, as implemented now.
rnk updated this object.
rnk added a reviewer: majnemer.
rnk added a subscriber: Unknown Object (MLST).
majnemer accepted this revision.Jan 29 2015, 2:29 PM
majnemer edited edge metadata.

LGTM

This revision is now accepted and ready to land.Jan 29 2015, 2:29 PM
This revision was automatically updated to reflect the committed changes.