Page MenuHomePhabricator

More robust deployment target parsing on darwin
ClosedPublic

Authored by steven_wu on Jan 12 2015, 3:00 PM.

Details

Summary

This is a more robust way of figuring out implicit deployment target
from isysroot. It also handles iphone simulator target.

Diff Detail

Repository
rL LLVM

Event Timeline

steven_wu updated this revision to Diff 18053.Jan 12 2015, 3:00 PM
steven_wu retitled this revision from to More robust deployment target parsing on darwin.
steven_wu updated this object.
steven_wu edited the test plan for this revision. (Show Details)
steven_wu added a reviewer: bob.wilson.
steven_wu added a subscriber: Unknown Object (MLST).

Hi Steven,

This mostly looks fine; just one comment:

steven_wu updated this revision to Diff 18097.Jan 13 2015, 10:53 AM
  • Using StringRef::npos according to Tim's suggestion
t.p.northover accepted this revision.Jan 13 2015, 4:09 PM
t.p.northover added a reviewer: t.p.northover.

Thanks Steven. I think this looks reasonable now.

Tim.

This revision is now accepted and ready to land.Jan 13 2015, 4:09 PM
This revision was automatically updated to reflect the committed changes.

I reverted this because green-dragon has some environment setting that causes testcase to break after this patch. Try to fix the bots before I recommit this patch.