Page MenuHomePhabricator

Refactor sanitizer build scripts.
ClosedPublic

Authored by earthdok on Dec 17 2014, 12:15 PM.

Details

Reviewers
eugenis
Summary
  • Move common code from buildbot_bootstrap.sh and buildbot_fast.sh to

buildbot_functions.sh.

  • Do not capitalize variable names needlessly.
  • Use mkdir -p where appropriate instead of "mdkir if directory does not exist".

Diff Detail

Event Timeline

earthdok updated this revision to Diff 17409.Dec 17 2014, 12:15 PM
earthdok retitled this revision from to Refactor sanitizer build scripts..
earthdok updated this object.
earthdok edited the test plan for this revision. (Show Details)
earthdok added a reviewer: eugenis.
earthdok added a subscriber: Unknown Object (MLST).
eugenis added inline comments.Dec 18 2014, 5:55 AM
zorg/buildbot/builders/sanitizers/buildbot_fast.sh
65

I think it would be better if stuff in buildbot_functions.sh did not rely on the STAGE2_MSAN_DIR and similar settings, and instead got them through function arguments. That would make it more reusable.
Ex.

build_stage2_msan "step name" <target directory> <previous stage compiler directory>

zorg/buildbot/builders/sanitizers/buildbot_functions.sh
99

these are debug leftovers, please remove

101

the comment is out of date, please remove it

123

local

eugenis accepted this revision.Dec 18 2014, 6:11 AM
eugenis edited edge metadata.
This revision is now accepted and ready to land.Dec 18 2014, 6:11 AM
earthdok updated this revision to Diff 17441.Dec 18 2014, 6:14 AM
earthdok edited edge metadata.
  • address nits
zorg/buildbot/builders/sanitizers/buildbot_fast.sh
65

As discussed offline, this is not worth the trobule

zorg/buildbot/builders/sanitizers/buildbot_functions.sh
99

Done.

101

Done.

123

done

earthdok closed this revision.Dec 18 2014, 6:40 AM

Committed r224520