Page MenuHomePhabricator

[xor.ll] Added Missing Check Statements for test cases
ClosedPublic

Authored by ankur29.garg on Nov 24 2014, 1:39 AM.

Details

Summary

Hi,
I've added missing 'CHECK' statements for the test cases in xor.ll.

Also checked the statements by running 'make check-all'.

Please review.

Thanks.
Ankur

Diff Detail

Repository
rL LLVM

Event Timeline

ankur29.garg retitled this revision from to [xor.ll] Added Missing Check Statements for test cases.
ankur29.garg updated this object.
ankur29.garg edited the test plan for this revision. (Show Details)
ankur29.garg added a reviewer: suyog.
ankur29.garg set the repository for this revision to rL LLVM.
ankur29.garg added a subscriber: Unknown Object (MLST).
suyog edited edge metadata.Nov 24 2014, 2:12 AM

Hi Ankur,

Please note that CHECK statements are used by FileCheck utility.
This test case uses grep to check for certain things.

So I will suggest you to either transform the whole test case to use the FileCheck utility
or leave it as it is to use grep for checking purpose. IMO, the original test case is correct and runs properly.

Regards,
Suyog

ankur29.garg edited edge metadata.

Hi Suyog,
Thanks for reviewing the changes.
I have made the appropriate changes to transform it to use FileCheck instead of grep.
I've also verified the check statements by running "make check-all"
Please review the updated diff.

Thanks.

suyog accepted this revision.Nov 25 2014, 12:39 AM
suyog edited edge metadata.

Looks fine now

This revision is now accepted and ready to land.Nov 25 2014, 12:39 AM
suyog closed this revision.Nov 25 2014, 12:45 AM
suyog updated this revision to Diff 16598.

Closed by commit rL222740 (authored by @suyog).