This is an archive of the discontinued LLVM Phabricator instance.

Differential D621

Add support for __GCC_HAVE_SYNC_COMPARE_AND_SWAP_{1,2,4,8} on x86.
ClosedPublic

Authored by Bigcheese on Apr 3 2013, 5:36 PM.

Details

Reviewers
Bigcheese
doug.gregor
Summary

This fixes std::thread with libstdc++.

Diff Detail

Event Timeline

Bigcheese added a comment.Apr 4 2013, 4:39 PM

ping

• rafael added a comment.Apr 4 2013, 4:43 PM

I checked the defines with the system gcc on fedora 17. LGTM

Bigcheese accepted this revision.Apr 4 2013, 4:55 PM
Bigcheese closed this revision.

r178816

Revision Contents

PathSize
lib/
Basic/
8 lines
test/
Preprocessor/
18 lines

Diff 1501

lib/Basic/Targets.cpp

Show First 20 Lines • Show All 2,724 Lines • ▼ Show 20 Lines case AMD3DNowAthlon:
Builder.defineMacro("__3dNOW_A__"); Builder.defineMacro("__3dNOW_A__");
case AMD3DNow: case AMD3DNow:
Builder.defineMacro("__3dNOW__"); Builder.defineMacro("__3dNOW__");
case MMX: case MMX:
Builder.defineMacro("__MMX__"); Builder.defineMacro("__MMX__");
case NoMMX3DNow: case NoMMX3DNow:
break; break;
} }
if (CPU >= CK_i486) {
Builder.defineMacro("__GCC_HAVE_SYNC_COMPARE_AND_SWAP_1");
Builder.defineMacro("__GCC_HAVE_SYNC_COMPARE_AND_SWAP_2");
Builder.defineMacro("__GCC_HAVE_SYNC_COMPARE_AND_SWAP_4");
}
if (CPU >= CK_i586)
Builder.defineMacro("__GCC_HAVE_SYNC_COMPARE_AND_SWAP_8");
} }
bool X86TargetInfo::hasFeature(StringRef Feature) const { bool X86TargetInfo::hasFeature(StringRef Feature) const {
return llvm::StringSwitch<bool>(Feature) return llvm::StringSwitch<bool>(Feature)
.Case("aes", HasAES) .Case("aes", HasAES)
.Case("avx", SSELevel >= AVX) .Case("avx", SSELevel >= AVX)
.Case("avx2", SSELevel >= AVX2) .Case("avx2", SSELevel >= AVX2)
.Case("bmi", HasBMI) .Case("bmi", HasBMI)
▲ Show 20 Lines • Show All 2,617 Lines • Show Last 20 Lines

test/Preprocessor/predefined-macros.c

Show All 20 Lines
// //
// RUN: %clang %s -E -dM -fno-finite-math-only -o - \ // RUN: %clang %s -E -dM -fno-finite-math-only -o - \
// RUN: | FileCheck %s --check-prefix=CHECK-NO-FINITE-MATH-ONLY // RUN: | FileCheck %s --check-prefix=CHECK-NO-FINITE-MATH-ONLY
// CHECK-NO-FINITE-MATH-ONLY: #define __FINITE_MATH_ONLY__ 0 // CHECK-NO-FINITE-MATH-ONLY: #define __FINITE_MATH_ONLY__ 0
// //
// RUN: %clang_cc1 %s -E -dM -o - \ // RUN: %clang_cc1 %s -E -dM -o - \
// RUN: | FileCheck %s --check-prefix=CHECK-FINITE-MATH-FLAG-UNDEFINED // RUN: | FileCheck %s --check-prefix=CHECK-FINITE-MATH-FLAG-UNDEFINED
// CHECK-FINITE-MATH-FLAG-UNDEFINED: #define __FINITE_MATH_ONLY__ 0 // CHECK-FINITE-MATH-FLAG-UNDEFINED: #define __FINITE_MATH_ONLY__ 0
//
// RUN: %clang_cc1 %s -E -dM -o - -triple i686 -target-cpu i386 \
// RUN: | FileCheck %s --check-prefix=CHECK-SYNC_CAS_I386
// CHECK-SYNC_CAS_I386-NOT: __GCC_HAVE_SYNC_COMPARE_AND_SWAP
//
// RUN: %clang_cc1 %s -E -dM -o - -triple i686 -target-cpu i486 \
// RUN: | FileCheck %s --check-prefix=CHECK-SYNC_CAS_I486
// CHECK-SYNC_CAS_I486: __GCC_HAVE_SYNC_COMPARE_AND_SWAP_1
// CHECK-SYNC_CAS_I486: __GCC_HAVE_SYNC_COMPARE_AND_SWAP_2
// CHECK-SYNC_CAS_I486: __GCC_HAVE_SYNC_COMPARE_AND_SWAP_4
// CHECK-SYNC_CAS_I486-NOT: __GCC_HAVE_SYNC_COMPARE_AND_SWAP_8
//
// RUN: %clang_cc1 %s -E -dM -o - -triple i686 -target-cpu i586 \
// RUN: | FileCheck %s --check-prefix=CHECK-SYNC_CAS_I586
// CHECK-SYNC_CAS_I586: __GCC_HAVE_SYNC_COMPARE_AND_SWAP_1
// CHECK-SYNC_CAS_I586: __GCC_HAVE_SYNC_COMPARE_AND_SWAP_2
// CHECK-SYNC_CAS_I586: __GCC_HAVE_SYNC_COMPARE_AND_SWAP_4
// CHECK-SYNC_CAS_I586: __GCC_HAVE_SYNC_COMPARE_AND_SWAP_8