This is an archive of the discontinued LLVM Phabricator instance.

[StackMaps] Add explicit location size accessor to the stackmap parser
ClosedPublic

Authored by jacob-hughes on Mar 8 2019, 5:04 PM.

Details

Summary

The reserved uint8 field in the location block of the stackmap record is used to denote the size of the location.

Diff Detail

Repository
rL LLVM

Event Timeline

jacob-hughes created this revision.Mar 8 2019, 5:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 8 2019, 5:04 PM
jacob-hughes retitled this revision from Add explicit location size accessor to the stackmap parser to [StackMaps] Add explicit location size accessor to the stackmap parser.
reames accepted this revision.Mar 11 2019, 10:47 AM

LGTM, thanks for splitting.

p.s. For those reading along, this is parsing the V2 format, not the V3 one in our current documentation. The original patch being split will update all of this to parse V3.

This revision is now accepted and ready to land.Mar 11 2019, 10:47 AM

Updated diff after rebasing from the latest master

This revision was automatically updated to reflect the committed changes.