This is an archive of the discontinued LLVM Phabricator instance.

X86_64 target now obeys llc -disable-red-zone option
Needs ReviewPublic

Authored by srking on Oct 8 2014, 1:52 PM.

Details

Reviewers
grosbach
Summary

X86_64 enables red zone optimization regardless of llc -disable-red-zone command line flag. This patch corrects this with a target option flag checked in X86FrameLowering::emitPrologue(). The existing x86_64 red-zone regression test is extended to check for this case.

Diff Detail

Event Timeline

srking updated this revision to Diff 14602.Oct 8 2014, 1:52 PM
srking retitled this revision from to X86_64 target now obeys llc -disable-red-zone option.
srking updated this object.
srking edited the test plan for this revision. (Show Details)
srking added a subscriber: Unknown Object (MLST).
rafael added a subscriber: rafael.

I think this is OK. Grosbach, what do you think?

include/llvm/Target/TargetOptions.h
195

Don't duplicate name in comment.

grosbach edited edge metadata.Oct 21 2014, 9:53 AM

Does this mean the clang -m[no-]red-zone option wasn't hooked up either? Does this fix that if so?

This patch is abandoned. See D6046.