Page MenuHomePhabricator

srking (Steve King)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 11 2014, 12:00 PM (257 w, 2 d)

Recent Activity

Oct 26 2015

srking added a comment to D14035: Fix llc crash processing S/UREM for -Oz builds caused by rL250825..

Commit r251373.

Oct 26 2015, 5:17 PM
srking committed rL251373: Fix llc crash processing S/UREM for -Oz builds caused by rL250825..
Fix llc crash processing S/UREM for -Oz builds caused by rL250825.
Oct 26 2015, 5:16 PM
srking added a comment to D14035: Fix llc crash processing S/UREM for -Oz builds caused by rL250825..
Oct 26 2015, 2:54 PM
srking updated the diff for D14035: Fix llc crash processing S/UREM for -Oz builds caused by rL250825..

Improved comment and added check in visitSDIV and visitUDIV in response to feedback from Artyom Skrobov.

Oct 26 2015, 2:50 PM
srking added inline comments to D14035: Fix llc crash processing S/UREM for -Oz builds caused by rL250825..
Oct 26 2015, 2:09 PM
srking updated the diff for D14035: Fix llc crash processing S/UREM for -Oz builds caused by rL250825..

Moved test to X86 directory and added new test functions without minsize attribute. X86 is a better home for the test since X86 returns different values for isIntDivCheap() depending on the minsize attribute.
Verified the test catches the crash bug when the s/urem fix is not in place.
Verified all tests pass with the fix.

Oct 26 2015, 10:19 AM

Oct 23 2015

srking added inline comments to D14035: Fix llc crash processing S/UREM for -Oz builds caused by rL250825..
Oct 23 2015, 7:24 PM
srking added inline comments to D14035: Fix llc crash processing S/UREM for -Oz builds caused by rL250825..
Oct 23 2015, 6:58 PM
srking retitled D14035: Fix llc crash processing S/UREM for -Oz builds caused by rL250825. from to Fix llc crash processing S/UREM for -Oz builds caused by rL250825..
Oct 23 2015, 5:42 PM

Aug 31 2015

srking retitled D12494: New IR pass: LoopExitValues from to New IR pass: LoopExitValues.
Aug 31 2015, 10:14 AM

Aug 24 2015

srking closed D12300: Pass function attributes instead of simple flag in isIntDivCheap target query. Add test cases..

r245921

Aug 24 2015, 8:27 PM
srking committed rL245921: Pass function attributes instead of boolean in isIntDivCheap()..
Pass function attributes instead of boolean in isIntDivCheap().
Aug 24 2015, 7:32 PM
srking added a comment to D12300: Pass function attributes instead of simple flag in isIntDivCheap target query. Add test cases..
Aug 24 2015, 6:17 PM
srking updated the diff for D12300: Pass function attributes instead of simple flag in isIntDivCheap target query. Add test cases..

Added new comment to tests.

Aug 24 2015, 6:15 PM
srking retitled D12300: Pass function attributes instead of simple flag in isIntDivCheap target query. Add test cases. from to Pass function attributes instead of simple flag in isIntDivCheap target query. Add test cases..
Aug 24 2015, 3:15 PM

Aug 19 2015

srking closed D8304: Fix backward operands in call to isTruncateFree() and improve comments..

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@245385 91177308-0d34-0410-b5e6-96231b3b80d8

Aug 19 2015, 11:43 AM

Aug 18 2015

srking committed rL245385: Fix backward operands in call to isTruncateFree() and improve comments..
Fix backward operands in call to isTruncateFree() and improve comments.
Aug 18 2015, 4:03 PM

Aug 13 2015

srking updated the diff for D8304: Fix backward operands in call to isTruncateFree() and improve comments..

Updated with improved comment from Hal Finkel.

Aug 13 2015, 9:26 AM

Aug 12 2015

srking committed rL244842: Test Commit - Corrected spelling in README.txt..
Test Commit - Corrected spelling in README.txt.
Aug 12 2015, 4:57 PM

Jul 28 2015

srking added inline comments to D8304: Fix backward operands in call to isTruncateFree() and improve comments..
Jul 28 2015, 1:39 PM
srking updated the diff for D8304: Fix backward operands in call to isTruncateFree() and improve comments..

Fix more old style comments caught by Jonathan. NFC.
The meaning of one of the original comments is mysterious. This patch does not clarify it.

Jul 28 2015, 12:38 PM
srking added inline comments to D8304: Fix backward operands in call to isTruncateFree() and improve comments..
Jul 28 2015, 12:33 PM
srking added a comment to D8304: Fix backward operands in call to isTruncateFree() and improve comments..

Do you have a testcase for this?

Jul 28 2015, 12:01 PM
srking updated the diff for D8304: Fix backward operands in call to isTruncateFree() and improve comments..

Tried to address review comments from Jonathan Roelofs. NFC from previous patch. Updated patch title text and summary to remove statement about asserts.

Jul 28 2015, 11:53 AM

Jul 15 2015

srking retitled D11236: ScalarEvolution: Make required passes transitive to prevent dangling pointers from to ScalarEvolution: Make required passes transitive to prevent dangling pointers.
Jul 15 2015, 12:19 PM

Mar 12 2015

srking updated the diff for D8304: Fix backward operands in call to isTruncateFree() and improve comments..

Removed the assert() due to cases that call isTruncateFree without regard to type size. Improved comment for these odd cases.
Verified regression checks pass.

Mar 12 2015, 4:28 PM
srking added a reviewer for D8304: Fix backward operands in call to isTruncateFree() and improve comments.: resistor.
Mar 12 2015, 1:00 PM
srking updated the diff for D8304: Fix backward operands in call to isTruncateFree() and improve comments..

Fixed patch file direction.

Mar 12 2015, 12:57 PM
srking added a comment to D8304: Fix backward operands in call to isTruncateFree() and improve comments..

Oops, patch is in wrong direction. Will upload new patch.

Mar 12 2015, 12:56 PM
srking retitled D8304: Fix backward operands in call to isTruncateFree() and improve comments. from to Fix backward operands in call to isTruncateFree() and add asserts..
Mar 12 2015, 12:13 PM

Nov 3 2014

srking updated the diff for D6106: Small update to gold plugin docs for building with CMake..

Use fixed point font for include path.

Nov 3 2014, 5:25 PM
srking retitled D6106: Small update to gold plugin docs for building with CMake. from to Small update to gold plugin docs for building with CMake..
Nov 3 2014, 5:16 PM

Oct 30 2014

srking added a comment to D5681: X86_64 target now obeys llc -disable-red-zone option.

This patch is abandoned. See D6046.

Oct 30 2014, 3:52 PM
srking retitled D6046: Remove -disable-red-zone command line option from LLC. from to Remove -disable-red-zone command line option from LLC..
Oct 30 2014, 3:51 PM

Oct 8 2014

srking retitled D5681: X86_64 target now obeys llc -disable-red-zone option from to X86_64 target now obeys llc -disable-red-zone option.
Oct 8 2014, 1:52 PM

Sep 26 2014

srking updated the diff for D5498: Fix TableGen -gen-disassembler output for certain bit field definitions..

Operator error: uploaded old patch again. Here is the new patch with renamed regression test file.

Sep 26 2014, 9:47 AM
srking updated the diff for D5498: Fix TableGen -gen-disassembler output for certain bit field definitions..

Changes from previous patch:

  1. Use more succinct test file name "BitOffsetDecoder.td"
  2. Update test file comments to use "offset" instead of "shift"
Sep 26 2014, 9:41 AM

Sep 25 2014

srking retitled D5498: Fix TableGen -gen-disassembler output for certain bit field definitions. from to Fix TableGen -gen-disassembler output for certain bit field definitions..
Sep 25 2014, 8:07 PM

Sep 10 2014

srking updated the diff for D5279: Add -bare option to llvm-objdump.

New patch file: reduce source churn by not alphabetizing llvm-objdump command line option definitions.
'make check' for all targets passes.

Sep 10 2014, 2:31 PM
srking added a comment to D5279: Add -bare option to llvm-objdump.

The -bare option keeps objdump output consistent with test expectations regardless of host platform. As discussed on the list, default llvm-objdump output could change per host: GNU style for Linux, otools for Apple, etc. Diagnostic tests cannot depend on the per-host default. Tests only need updating (a tedious process) if -bare output changes.

Sep 10 2014, 1:38 PM

Sep 9 2014

srking retitled D5279: Add -bare option to llvm-objdump from to Add -bare option to llvm-objdump.
Sep 9 2014, 4:16 PM

Aug 13 2014

srking updated the diff for D4868: llvm-objdump bug may hide a single-byte instruction near a label..

New patch uploaded:

  1. Moved test file to X86 subdirectory
  2. Ungrouped code comments.
Aug 13 2014, 1:18 PM · deleted

Aug 12 2014

srking added a comment to D4868: llvm-objdump bug may hide a single-byte instruction near a label..

I also wondered about the best location for the input file. The bug is not specific to x86 and there is precedence for x86 files in the Inputs directory, so I just chose that location. I don't care where the test input ultimately lands, but I'll leave it as-is unless somebody insists to move it.

Aug 12 2014, 4:48 PM · deleted
srking retitled D4868: llvm-objdump bug may hide a single-byte instruction near a label. from to llvm-objdump bug may hide a single-byte instruction near a label..
Aug 12 2014, 8:50 AM · deleted
srking abandoned D4858: llvm-objdump bug may hide single byte instructions near a label..

Resubmitting with proper Phabricator fields.

Aug 12 2014, 8:43 AM · deleted

Aug 11 2014

srking added a reviewer for D4858: llvm-objdump bug may hide single byte instructions near a label.: deleted.
Aug 11 2014, 6:18 PM · deleted
srking retitled D4858: llvm-objdump bug may hide single byte instructions near a label. from to llvm-objdump bug may hide single byte instructions near a label..
Aug 11 2014, 5:41 PM · deleted