Forbid combination of --status-bugs and non-HTML output

[rkday]

Summary

I recently spent some time resolving an issue where the --status-bugs parameter conflicted with -plist, and scan-build always returned 0 even when there were errors.

This change means that scan-build rejects these as incompatible arguments.

I've tested that this works with this test program:

$ cat test.c
int abcd(char* x, char* y)
{
	strcpy(x, y);
}

int main()
{
	return 0;
}

and these two commands:

./bin/scan-build --status-bugs -enable-checker security --use-analyzer /usr/bin/clang clang test.c; echo $?

./bin/scan-build --status-bugs -plist -enable-checker security --use-analyzer /usr/bin/clang clang test.c; echo $?

bin/scan-build

if (!defined $Cmd || ! -e $Cmd) {
   $Cmd = "$AbsRealBin/ccc-analyzer";
   DieDiag("'ccc-analyzer' does not exist at '$Cmd'\n") if(! -e $Cmd);
 }
 if (!defined $CmdCXX || ! -e $CmdCXX) {
   $CmdCXX = "$AbsRealBin/c++-analyzer";
   DieDiag("'c++-analyzer' does not exist at '$CmdCXX'\n") if(! -e $CmdCXX);
 }
 
+if ($Options{ExitStatusFoundBugs} == 1 && !($Options{OutputFormat} =~ /html/)) {
+  DieDiag("--status-bugs is only supported with the HTML output format\n");
+}
+
 Diag("Using '$Clang' for static analysis\n");
 
 SetHtmlEnv(\@ARGV, $Options{OutputDir});
 
 my @AnalysesToRun;
 foreach (sort { $Options{EnableCheckers}{$a} <=> $Options{EnableCheckers}{$b} }
          keys %{$Options{EnableCheckers}}) {
   # Push checkers in order they were enabled.