This is an archive of the discontinued LLVM Phabricator instance.

Differential D49745

Generate fundamental type info with weak linkage
AbandonedPublic

Authored by thomasanderson on Jul 24 2018, 10:54 AM.

Details

Reviewers
pcc

Diff Detail

Event Timeline

thomasanderson created this revision.Jul 24 2018, 10:54 AM
pcc requested changes to this revision.Jul 24 2018, 11:06 AM

As I mentioned in https://bugs.llvm.org/show_bug.cgi?id=38281 I don't see a good reason to do this. Also extern_weak is not an appropriate linkage for definitions, only declarations.

This revision now requires changes to proceed.Jul 24 2018, 11:06 AM
thomasanderson abandoned this revision.Jul 24 2018, 11:13 AM

Revision Contents

PathSize
lib/
CodeGen/
2 lines
test/
CodeGenCXX/
276 lines
4 lines

Diff 157080

lib/CodeGen/ItaniumCXXABI.cpp

Show First 20 Lines • Show All 3,683 Lines • ▼ Show 20 Linesvoid ItaniumCXXABI::EmitFundamentalRTTIDescriptors(const CXXRecordDecl *RD) {
llvm::GlobalValue::VisibilityTypes Visibility = llvm::GlobalValue::VisibilityTypes Visibility =
CodeGenModule::GetLLVMVisibility(RD->getVisibility()); CodeGenModule::GetLLVMVisibility(RD->getVisibility());
for (const QualType &FundamentalType : FundamentalTypes) { for (const QualType &FundamentalType : FundamentalTypes) {
QualType PointerType = getContext().getPointerType(FundamentalType); QualType PointerType = getContext().getPointerType(FundamentalType);
QualType PointerTypeConst = getContext().getPointerType( QualType PointerTypeConst = getContext().getPointerType(
FundamentalType.withConst()); FundamentalType.withConst());
for (QualType Type : {FundamentalType, PointerType, PointerTypeConst}) for (QualType Type : {FundamentalType, PointerType, PointerTypeConst})
ItaniumRTTIBuilder(*this).BuildTypeInfo( ItaniumRTTIBuilder(*this).BuildTypeInfo(
Type, llvm::GlobalValue::ExternalLinkage, Type, llvm::GlobalValue::ExternalWeakLinkage,
Visibility, DLLStorageClass); Visibility, DLLStorageClass);
} }
} }
/// What sort of uniqueness rules should we use for the RTTI for the /// What sort of uniqueness rules should we use for the RTTI for the
/// given type? /// given type?
ItaniumCXXABI::RTTIUniquenessKind ItaniumCXXABI::classifyRTTIUniqueness( ItaniumCXXABI::RTTIUniquenessKind ItaniumCXXABI::classifyRTTIUniqueness(
QualType CanTy, llvm::GlobalValue::LinkageTypes Linkage) const { QualType CanTy, llvm::GlobalValue::LinkageTypes Linkage) const {
▲ Show 20 Lines • Show All 538 Lines • Show Last 20 Lines

test/CodeGenCXX/rtti-fundamental.cpp

Show All 10 Linesnamespace __cxxabiv1 {
struct __fundamental_type_info { struct __fundamental_type_info {
virtual ~__fundamental_type_info(); virtual ~__fundamental_type_info();
}; };
__fundamental_type_info::~__fundamental_type_info() { } __fundamental_type_info::~__fundamental_type_info() { }
} }
// void // void
// CHECK: @_ZTIv = constant // CHECK: @_ZTIv = extern_weak constant
// CHECK-HIDDEN: @_ZTIv = hidden constant // CHECK-HIDDEN: @_ZTIv = extern_weak hidden constant
// CHECK: @_ZTIPv = constant // CHECK: @_ZTIPv = extern_weak constant
// CHECK-HIDDEN: @_ZTIPv = hidden constant // CHECK-HIDDEN: @_ZTIPv = extern_weak hidden constant
// CHECK: @_ZTIPKv = constant // CHECK: @_ZTIPKv = extern_weak constant
// CHECK-HIDDEN: @_ZTIPKv = hidden constant // CHECK-HIDDEN: @_ZTIPKv = extern_weak hidden constant
// std::nullptr_t // std::nullptr_t
// CHECK: @_ZTIDn = constant // CHECK: @_ZTIDn = extern_weak constant
// CHECK-HIDDEN: @_ZTIDn = hidden constant // CHECK-HIDDEN: @_ZTIDn = extern_weak hidden constant
// CHECK: @_ZTIPDn = constant // CHECK: @_ZTIPDn = extern_weak constant
// CHECK-HIDDEN: @_ZTIPDn = hidden constant // CHECK-HIDDEN: @_ZTIPDn = extern_weak hidden constant
// CHECK: @_ZTIPKDn = constant // CHECK: @_ZTIPKDn = extern_weak constant
// CHECK-HIDDEN: @_ZTIPKDn = hidden constant // CHECK-HIDDEN: @_ZTIPKDn = extern_weak hidden constant
// bool // bool
// CHECK: @_ZTIb = constant // CHECK: @_ZTIb = extern_weak constant
// CHECK-HIDDEN: @_ZTIb = hidden constant // CHECK-HIDDEN: @_ZTIb = extern_weak hidden constant
// CHECK: @_ZTIPb = constant // CHECK: @_ZTIPb = extern_weak constant
// CHECK-HIDDEN: @_ZTIPb = hidden constant // CHECK-HIDDEN: @_ZTIPb = extern_weak hidden constant
// CHECK: @_ZTIPKb = constant // CHECK: @_ZTIPKb = extern_weak constant
// CHECK-HIDDEN: @_ZTIPKb = hidden constant // CHECK-HIDDEN: @_ZTIPKb = extern_weak hidden constant
// wchar_t // wchar_t
// CHECK: @_ZTIw = constant // CHECK: @_ZTIw = extern_weak constant
// CHECK-HIDDEN: @_ZTIw = hidden constant // CHECK-HIDDEN: @_ZTIw = extern_weak hidden constant
// CHECK: @_ZTIPw = constant // CHECK: @_ZTIPw = extern_weak constant
// CHECK-HIDDEN: @_ZTIPw = hidden constant // CHECK-HIDDEN: @_ZTIPw = extern_weak hidden constant
// CHECK: @_ZTIPKw = constant // CHECK: @_ZTIPKw = extern_weak constant
// CHECK-HIDDEN: @_ZTIPKw = hidden constant // CHECK-HIDDEN: @_ZTIPKw = extern_weak hidden constant
// char // char
// CHECK: @_ZTIc = constant // CHECK: @_ZTIc = extern_weak constant
// CHECK-HIDDEN: @_ZTIc = hidden constant // CHECK-HIDDEN: @_ZTIc = extern_weak hidden constant
// CHECK: @_ZTIPc = constant // CHECK: @_ZTIPc = extern_weak constant
// CHECK-HIDDEN: @_ZTIPc = hidden constant // CHECK-HIDDEN: @_ZTIPc = extern_weak hidden constant
// CHECK: @_ZTIPKc = constant // CHECK: @_ZTIPKc = extern_weak constant
// CHECK-HIDDEN: @_ZTIPKc = hidden constant // CHECK-HIDDEN: @_ZTIPKc = extern_weak hidden constant
// unsigned char // unsigned char
// CHECK: @_ZTIh = constant // CHECK: @_ZTIh = extern_weak constant
// CHECK-HIDDEN: @_ZTIh = hidden constant // CHECK-HIDDEN: @_ZTIh = extern_weak hidden constant
// CHECK: @_ZTIPh = constant // CHECK: @_ZTIPh = extern_weak constant
// CHECK-HIDDEN: @_ZTIPh = hidden constant // CHECK-HIDDEN: @_ZTIPh = extern_weak hidden constant
// CHECK: @_ZTIPKh = constant // CHECK: @_ZTIPKh = extern_weak constant
// CHECK-HIDDEN: @_ZTIPKh = hidden constant // CHECK-HIDDEN: @_ZTIPKh = extern_weak hidden constant
// signed char // signed char
// CHECK: @_ZTIa = constant // CHECK: @_ZTIa = extern_weak constant
// CHECK-HIDDEN: @_ZTIa = hidden constant // CHECK-HIDDEN: @_ZTIa = extern_weak hidden constant
// CHECK: @_ZTIPa = constant // CHECK: @_ZTIPa = extern_weak constant
// CHECK-HIDDEN: @_ZTIPa = hidden constant // CHECK-HIDDEN: @_ZTIPa = extern_weak hidden constant
// CHECK: @_ZTIPKa = constant // CHECK: @_ZTIPKa = extern_weak constant
// CHECK-HIDDEN: @_ZTIPKa = hidden constant // CHECK-HIDDEN: @_ZTIPKa = extern_weak hidden constant
// short // short
// CHECK: @_ZTIs = constant // CHECK: @_ZTIs = extern_weak constant
// CHECK-HIDDEN: @_ZTIs = hidden constant // CHECK-HIDDEN: @_ZTIs = extern_weak hidden constant
// CHECK: @_ZTIPs = constant // CHECK: @_ZTIPs = extern_weak constant
// CHECK-HIDDEN: @_ZTIPs = hidden constant // CHECK-HIDDEN: @_ZTIPs = extern_weak hidden constant
// CHECK: @_ZTIPKs = constant // CHECK: @_ZTIPKs = extern_weak constant
// CHECK-HIDDEN: @_ZTIPKs = hidden constant // CHECK-HIDDEN: @_ZTIPKs = extern_weak hidden constant
// unsigned short // unsigned short
// CHECK: @_ZTIt = constant // CHECK: @_ZTIt = extern_weak constant
// CHECK-HIDDEN: @_ZTIt = hidden constant // CHECK-HIDDEN: @_ZTIt = extern_weak hidden constant
// CHECK: @_ZTIPt = constant // CHECK: @_ZTIPt = extern_weak constant
// CHECK-HIDDEN: @_ZTIPt = hidden constant // CHECK-HIDDEN: @_ZTIPt = extern_weak hidden constant
// CHECK: @_ZTIPKt = constant // CHECK: @_ZTIPKt = extern_weak constant
// CHECK-HIDDEN: @_ZTIPKt = hidden constant // CHECK-HIDDEN: @_ZTIPKt = extern_weak hidden constant
// int // int
// CHECK: @_ZTIi = constant // CHECK: @_ZTIi = extern_weak constant
// CHECK-HIDDEN: @_ZTIi = hidden constant // CHECK-HIDDEN: @_ZTIi = extern_weak hidden constant
// CHECK: @_ZTIPi = constant // CHECK: @_ZTIPi = extern_weak constant
// CHECK-HIDDEN: @_ZTIPi = hidden constant // CHECK-HIDDEN: @_ZTIPi = extern_weak hidden constant
// CHECK: @_ZTIPKi = constant // CHECK: @_ZTIPKi = extern_weak constant
// CHECK-HIDDEN: @_ZTIPKi = hidden constant // CHECK-HIDDEN: @_ZTIPKi = extern_weak hidden constant
// unsigned int // unsigned int
// CHECK: @_ZTIj = constant // CHECK: @_ZTIj = extern_weak constant
// CHECK-HIDDEN: @_ZTIj = hidden constant // CHECK-HIDDEN: @_ZTIj = extern_weak hidden constant
// CHECK: @_ZTIPj = constant // CHECK: @_ZTIPj = extern_weak constant
// CHECK-HIDDEN: @_ZTIPj = hidden constant // CHECK-HIDDEN: @_ZTIPj = extern_weak hidden constant
// CHECK: @_ZTIPKj = constant // CHECK: @_ZTIPKj = extern_weak constant
// CHECK-HIDDEN: @_ZTIPKj = hidden constant // CHECK-HIDDEN: @_ZTIPKj = extern_weak hidden constant
// long // long
// CHECK: @_ZTIl = constant // CHECK: @_ZTIl = extern_weak constant
// CHECK-HIDDEN: @_ZTIl = hidden constant // CHECK-HIDDEN: @_ZTIl = extern_weak hidden constant
// CHECK: @_ZTIPl = constant // CHECK: @_ZTIPl = extern_weak constant
// CHECK-HIDDEN: @_ZTIPl = hidden constant // CHECK-HIDDEN: @_ZTIPl = extern_weak hidden constant
// CHECK: @_ZTIPKl = constant // CHECK: @_ZTIPKl = extern_weak constant
// CHECK-HIDDEN: @_ZTIPKl = hidden constant // CHECK-HIDDEN: @_ZTIPKl = extern_weak hidden constant
// unsigned long // unsigned long
// CHECK: @_ZTIm = constant // CHECK: @_ZTIm = extern_weak constant
// CHECK-HIDDEN: @_ZTIm = hidden constant // CHECK-HIDDEN: @_ZTIm = extern_weak hidden constant
// CHECK: @_ZTIPm = constant // CHECK: @_ZTIPm = extern_weak constant
// CHECK-HIDDEN: @_ZTIPm = hidden constant // CHECK-HIDDEN: @_ZTIPm = extern_weak hidden constant
// CHECK: @_ZTIPKm = constant // CHECK: @_ZTIPKm = extern_weak constant
// CHECK-HIDDEN: @_ZTIPKm = hidden constant // CHECK-HIDDEN: @_ZTIPKm = extern_weak hidden constant
// long long // long long
// CHECK: @_ZTIx = constant // CHECK: @_ZTIx = extern_weak constant
// CHECK-HIDDEN: @_ZTIx = hidden constant // CHECK-HIDDEN: @_ZTIx = extern_weak hidden constant
// CHECK: @_ZTIPx = constant // CHECK: @_ZTIPx = extern_weak constant
// CHECK-HIDDEN: @_ZTIPx = hidden constant // CHECK-HIDDEN: @_ZTIPx = extern_weak hidden constant
// CHECK: @_ZTIPKx = constant // CHECK: @_ZTIPKx = extern_weak constant
// CHECK-HIDDEN: @_ZTIPKx = hidden constant // CHECK-HIDDEN: @_ZTIPKx = extern_weak hidden constant
// unsigned long long // unsigned long long
// CHECK: @_ZTIy = constant // CHECK: @_ZTIy = extern_weak constant
// CHECK-HIDDEN: @_ZTIy = hidden constant // CHECK-HIDDEN: @_ZTIy = extern_weak hidden constant
// CHECK: @_ZTIPy = constant // CHECK: @_ZTIPy = extern_weak constant
// CHECK-HIDDEN: @_ZTIPy = hidden constant // CHECK-HIDDEN: @_ZTIPy = extern_weak hidden constant
// CHECK: @_ZTIPKy = constant // CHECK: @_ZTIPKy = extern_weak constant
// CHECK-HIDDEN: @_ZTIPKy = hidden constant // CHECK-HIDDEN: @_ZTIPKy = extern_weak hidden constant
// __int128 // __int128
// CHECK: @_ZTIn = constant // CHECK: @_ZTIn = extern_weak constant
// CHECK-HIDDEN: @_ZTIn = hidden constant // CHECK-HIDDEN: @_ZTIn = extern_weak hidden constant
// CHECK: @_ZTIPn = constant // CHECK: @_ZTIPn = extern_weak constant
// CHECK-HIDDEN: @_ZTIPn = hidden constant // CHECK-HIDDEN: @_ZTIPn = extern_weak hidden constant
// CHECK: @_ZTIPKn = constant // CHECK: @_ZTIPKn = extern_weak constant
// CHECK-HIDDEN: @_ZTIPKn = hidden constant // CHECK-HIDDEN: @_ZTIPKn = extern_weak hidden constant
// unsigned __int128 // unsigned __int128
// CHECK: @_ZTIo = constant // CHECK: @_ZTIo = extern_weak constant
// CHECK-HIDDEN: @_ZTIo = hidden constant // CHECK-HIDDEN: @_ZTIo = extern_weak hidden constant
// CHECK: @_ZTIPo = constant // CHECK: @_ZTIPo = extern_weak constant
// CHECK-HIDDEN: @_ZTIPo = hidden constant // CHECK-HIDDEN: @_ZTIPo = extern_weak hidden constant
// CHECK: @_ZTIPKo = constant // CHECK: @_ZTIPKo = extern_weak constant
// CHECK-HIDDEN: @_ZTIPKo = hidden constant // CHECK-HIDDEN: @_ZTIPKo = extern_weak hidden constant
// half // half
// CHECK: @_ZTIDh = constant // CHECK: @_ZTIDh = extern_weak constant
// CHECK-HIDDEN: @_ZTIDh = hidden constant // CHECK-HIDDEN: @_ZTIDh = extern_weak hidden constant
// CHECK: @_ZTIPDh = constant // CHECK: @_ZTIPDh = extern_weak constant
// CHECK-HIDDEN: @_ZTIPDh = hidden constant // CHECK-HIDDEN: @_ZTIPDh = extern_weak hidden constant
// CHECK: @_ZTIPKDh = constant // CHECK: @_ZTIPKDh = extern_weak constant
// CHECK-HIDDEN: @_ZTIPKDh = hidden constant // CHECK-HIDDEN: @_ZTIPKDh = extern_weak hidden constant
// float // float
// CHECK: @_ZTIf = constant // CHECK: @_ZTIf = extern_weak constant
// CHECK-HIDDEN: @_ZTIf = hidden constant // CHECK-HIDDEN: @_ZTIf = extern_weak hidden constant
// CHECK: @_ZTIPf = constant // CHECK: @_ZTIPf = extern_weak constant
// CHECK-HIDDEN: @_ZTIPf = hidden constant // CHECK-HIDDEN: @_ZTIPf = extern_weak hidden constant
// CHECK: @_ZTIPKf = constant // CHECK: @_ZTIPKf = extern_weak constant
// CHECK-HIDDEN: @_ZTIPKf = hidden constant // CHECK-HIDDEN: @_ZTIPKf = extern_weak hidden constant
// double // double
// CHECK: @_ZTId = constant // CHECK: @_ZTId = extern_weak constant
// CHECK-HIDDEN: @_ZTId = hidden constant // CHECK-HIDDEN: @_ZTId = extern_weak hidden constant
// CHECK: @_ZTIPd = constant // CHECK: @_ZTIPd = extern_weak constant
// CHECK-HIDDEN: @_ZTIPd = hidden constant // CHECK-HIDDEN: @_ZTIPd = extern_weak hidden constant
// CHECK: @_ZTIPKd = constant // CHECK: @_ZTIPKd = extern_weak constant
// CHECK-HIDDEN: @_ZTIPKd = hidden constant // CHECK-HIDDEN: @_ZTIPKd = extern_weak hidden constant
// long double // long double
// CHECK: @_ZTIe = constant // CHECK: @_ZTIe = extern_weak constant
// CHECK-HIDDEN: @_ZTIe = hidden constant // CHECK-HIDDEN: @_ZTIe = extern_weak hidden constant
// CHECK: @_ZTIPe = constant // CHECK: @_ZTIPe = extern_weak constant
// CHECK-HIDDEN: @_ZTIPe = hidden constant // CHECK-HIDDEN: @_ZTIPe = extern_weak hidden constant
// CHECK: @_ZTIPKe = constant // CHECK: @_ZTIPKe = extern_weak constant
// CHECK-HIDDEN: @_ZTIPKe = hidden constant // CHECK-HIDDEN: @_ZTIPKe = extern_weak hidden constant
// char16_t // char16_t
// CHECK: @_ZTIDs = constant // CHECK: @_ZTIDs = extern_weak constant
// CHECK-HIDDEN: @_ZTIDs = hidden constant // CHECK-HIDDEN: @_ZTIDs = extern_weak hidden constant
// CHECK: @_ZTIPDs = constant // CHECK: @_ZTIPDs = extern_weak constant
// CHECK-HIDDEN: @_ZTIPDs = hidden constant // CHECK-HIDDEN: @_ZTIPDs = extern_weak hidden constant
// CHECK: @_ZTIPKDs = constant // CHECK: @_ZTIPKDs = extern_weak constant
// CHECK-HIDDEN: @_ZTIPKDs = hidden constant // CHECK-HIDDEN: @_ZTIPKDs = extern_weak hidden constant
// char32_t // char32_t
// CHECK: @_ZTIDi = constant // CHECK: @_ZTIDi = extern_weak constant
// CHECK-HIDDEN: @_ZTIDi = hidden constant // CHECK-HIDDEN: @_ZTIDi = extern_weak hidden constant
// CHECK: @_ZTIPDi = constant // CHECK: @_ZTIPDi = extern_weak constant
// CHECK-HIDDEN: @_ZTIPDi = hidden constant // CHECK-HIDDEN: @_ZTIPDi = extern_weak hidden constant
// CHECK: @_ZTIPKDi = constant // CHECK: @_ZTIPKDi = extern_weak constant
// CHECK-HIDDEN: @_ZTIPKDi = hidden constant // CHECK-HIDDEN: @_ZTIPKDi = extern_weak hidden constant

test/CodeGenCXX/windows-itanium-type-info.cpp

Show All 18 Lines
derived::~derived() { derived::~derived() {
method(); method();
} }
void f() { void f() {
throw base(); throw base();
} }
// CHECK-DAG: @_ZTIi = dso_local dllexport constant // CHECK-DAG: @_ZTIi = extern_weak dso_local dllexport constant
// CHECK-DAG: @_ZTSi = dso_local dllexport constant // CHECK-DAG: @_ZTSi = extern_weak dso_local dllexport constant
// CHECK-DAG: @_ZTI7derived = dso_local dllexport constant // CHECK-DAG: @_ZTI7derived = dso_local dllexport constant
// CHECK-DAG: @_ZTS7derived = dso_local dllexport constant // CHECK-DAG: @_ZTS7derived = dso_local dllexport constant
// CHECK-DAG: @_ZTV7derived = dso_local dllexport unnamed_addr constant // CHECK-DAG: @_ZTV7derived = dso_local dllexport unnamed_addr constant
// CHECK-DAG: @_ZTI4base = external dllimport constant // CHECK-DAG: @_ZTI4base = external dllimport constant
// CHECK-EH-IMPORT: @_ZTS4base = linkonce_odr dso_local constant // CHECK-EH-IMPORT: @_ZTS4base = linkonce_odr dso_local constant
Show All 10 Lines