Page MenuHomePhabricator

Add an option to specify function name when view/print CFG
ClosedPublic

Authored by davidxl on Jul 17 2018, 1:17 PM.

Details

Diff Detail

Repository
rL LLVM

Event Timeline

davidxl created this revision.Jul 17 2018, 1:17 PM
eraman accepted this revision.Jul 24 2018, 10:10 PM

LGTM with a change to the option description .

lib/Analysis/CFGPrinter.cpp
27 ↗(On Diff #155953)

The description string doesn't need to have "The option to specify ...". Instead "Name of the function (or its substring) whose..." looks better to me.

This revision is now accepted and ready to land.Jul 24 2018, 10:10 PM
This revision was automatically updated to reflect the committed changes.
davidxl marked an inline comment as done.