This is an archive of the discontinued LLVM Phabricator instance.

X86AsmPrinter MCJIT MSVC bug fix.
ClosedPublic

Authored by jklontz on Aug 12 2014, 11:58 AM.

Details

Summary

This bug was introduced in r213006 which makes an assumption that MCSection is COFF for Windows MSVC. This assumption is broken for MCJIT users where ELF is used instead [1]. The fix is to change the MCSection cast to a dyn_cast.

[1] http://lists.cs.uiuc.edu/pipermail/llvmdev/2013-December/068407.html.

Diff Detail

Event Timeline

jklontz updated this revision to Diff 12410.Aug 12 2014, 11:58 AM
jklontz retitled this revision from to X86AsmPrinter MCJIT MSVC bug fix..
jklontz updated this object.
jklontz edited the test plan for this revision. (Show Details)
jklontz added a reviewer: majnemer.
jklontz added a subscriber: Unknown Object (MLST).
majnemer accepted this revision.Aug 13 2014, 4:06 PM
majnemer edited edge metadata.

LGTM

This revision is now accepted and ready to land.Aug 13 2014, 4:06 PM
jklontz closed this revision.Aug 21 2014, 6:04 AM
jklontz updated this revision to Diff 12762.

Closed by commit rL216173 (authored by @jklontz).