Page MenuHomePhabricator

lldb - ELF: ARM64 relocation jump slot type
ClosedPublic

Authored by pawelo on Jul 17 2014, 10:58 PM.

Details

Reviewers
tfiala
Summary

One more small step toward ARM64/AArch64 support.
WARNING! D4488 on LLVM must be committed first.

Diff Detail

Event Timeline

pawelo updated this revision to Diff 11630.Jul 17 2014, 10:58 PM
pawelo retitled this revision from to lldb - ELF: ARM64 relocation jump slot type.
pawelo updated this object.
pawelo edited the test plan for this revision. (Show Details)
pawelo set the repository for this revision to rL LLVM.
pawelo added a subscriber: Unknown Object (MLST).
tfiala edited edge metadata.Aug 19 2014, 10:17 AM

Hey Paul, did this go in while I was on vacation?

Similar patch was accepted later which adds missing R_AARCH64_JUMP_SLOT constant, so it builds fine now.

tfiala accepted this revision.Aug 19 2014, 1:05 PM
tfiala edited edge metadata.

Okay - thanks Paul. Closing out. Listing as accepted with understanding this already went in (albeit slightly differently).

This revision is now accepted and ready to land.Aug 19 2014, 1:05 PM
tfiala closed this revision.Aug 19 2014, 1:05 PM

As with D4580, I misread the WARNING! D4488 on LLVM must be committed first. part to mean this already went in.

Reviewed, tested, submitted:

svn commit
Sending        source/Plugins/ObjectFile/ELF/ELFHeader.cpp
Transmitting file data .
Committed revision 216739.