Page MenuHomePhabricator

MRI delete command
ClosedPublic

Authored by dmikulin on Mar 1 2018, 5:03 PM.

Details

Summary

A far-from-perfect attempt at MRI delete command.
llvm-ar is not very well set up to handle multiple types of commands in the same script...
Need to add a test case.

Diff Detail

Repository
rL LLVM

Event Timeline

dmikulin created this revision.Mar 1 2018, 5:03 PM

I'm not sure about this one. I've added Rafael as a reviewer as he's on the blame for most of this code.

dmikulin updated this revision to Diff 136782.Mar 2 2018, 10:00 AM

llvm-ar supports only a subset of MRI commands, that's why 'delete' as implemented here only works for a specific use case: deleting members added with 'addlib' or 'addmod' commands during archive creation.

dmikulin updated this revision to Diff 136834.Mar 2 2018, 12:55 PM

Changed the implementation to avoid writing the archive twice.

dmikulin updated this revision to Diff 136846.Mar 2 2018, 1:55 PM

Changed deleteMember() to erase_if()

This revision was not accepted when it landed; it landed in state Needs Review.Mar 2 2018, 3:26 PM
Closed by commit rL326636: Implementation of MRI "delete" command. (authored by dmikulin, committed by ). · Explain Why
This revision was automatically updated to reflect the committed changes.