Page MenuHomePhabricator

Invalidate process uid/gid command options on Windows
ClosedPublic

Authored by zturner on Jul 3 2014, 2:24 AM.

Details

Summary

This patch implements the core logic to invalidate command options based on the interpreter state, and uses this to invalidate uid/gid related options of the "platform process list" command on Windows.

When an invalid option is specified for a command, an error message is printed that explains the reason that the option is invalid, and furthermore when the help of a command is printed, options which have runtime validity conditions display an abbreviated-condition string in square braces prior to the long description of the option.

Diff Detail

Repository
rL LLVM

Event Timeline

zturner updated this revision to Diff 11047.Jul 3 2014, 2:24 AM
zturner retitled this revision from to Invalidate process uid/gid command options on Windows.
zturner updated this object.
zturner edited the test plan for this revision. (Show Details)
zturner added a subscriber: Unknown Object (MLST).
zturner updated this revision to Diff 11127.Jul 7 2014, 1:21 PM

Update the patch to take both an ExecutionContext and a Platform independently of each other. The core logic has not changed, this particular validator still goes through the Platform and ignores the Target, since there may be no target running.

zturner closed this revision.Jul 7 2014, 5:03 PM
zturner updated this revision to Diff 11135.

Closed by commit rL212500 (authored by @zturner).