This is an archive of the discontinued LLVM Phabricator instance.

Differential D38502

allow access decl without using keyword when emulate msvc
Needs ReviewPublic

Authored by comicfans44 on Oct 3 2017, 6:42 AM.

Details

Reviewers
cfe-commits
Summary

msvc allow such code construction in vs2010 / vs2017 , needs someone check this behavior in VS2012/VS2013/VS2015

Diff Detail

Repository
rL LLVM

Event Timeline

comicfans44 created this revision.Oct 3 2017, 6:42 AM
comicfans44 added a subscriber: cfe-commits.Oct 3 2017, 6:47 AM

Revision Contents

PathSize
clang/
lib/
Sema/
9 lines

Diff 117517

clang/lib/Sema/SemaDeclCXX.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 8,972 Lines • ▼ Show 20 LinesDecl *Sema::ActOnUsingDeclaration(Scope *S,
} }
DeclarationNameInfo TargetNameInfo = GetNameFromUnqualifiedId(Name); DeclarationNameInfo TargetNameInfo = GetNameFromUnqualifiedId(Name);
DeclarationName TargetName = TargetNameInfo.getName(); DeclarationName TargetName = TargetNameInfo.getName();
if (!TargetName) if (!TargetName)
return nullptr; return nullptr;
// Warn about access declarations. // Warn about access declarations.
// MSVC allow access decl without using
if (UsingLoc.isInvalid()) { if (UsingLoc.isInvalid()) {
Diag(Name.getLocStart(), Diag(Name.getLocStart(),
getLangOpts().CPlusPlus11 ? diag::err_access_decl getLangOpts().MSVCCompat
: diag::warn_access_decl_deprecated) ? diag::warn_access_decl_deprecated
: (getLangOpts().CPlusPlus11 ? diag::err_access_decl
: diag::warn_access_decl_deprecated))
<< FixItHint::CreateInsertion(SS.getRange().getBegin(), "using "); << FixItHint::CreateInsertion(SS.getRange().getBegin(), "using ");
} }
if (EllipsisLoc.isInvalid()) { if (EllipsisLoc.isInvalid()) {
if (DiagnoseUnexpandedParameterPack(SS, UPPC_UsingDeclaration) || if (DiagnoseUnexpandedParameterPack(SS, UPPC_UsingDeclaration) ||
DiagnoseUnexpandedParameterPack(TargetNameInfo, UPPC_UsingDeclaration)) DiagnoseUnexpandedParameterPack(TargetNameInfo, UPPC_UsingDeclaration))
return nullptr; return nullptr;
} else { } else {
if (!SS.getScopeRep()->containsUnexpandedParameterPack() && if (!SS.getScopeRep()->containsUnexpandedParameterPack() &&
▲ Show 20 Lines • Show All 6,004 Lines • Show Last 20 Lines