This is an archive of the discontinued LLVM Phabricator instance.

Update Scudo allocator documentation.
ClosedPublic

Authored by flowerhack on Aug 28 2017, 4:19 PM.

Details

Summary

QuarantineSizeMb is deprecated, and QuarantineChunksUpToSize has been added as a new tunable option.

Diff Detail

Event Timeline

flowerhack created this revision.Aug 28 2017, 4:19 PM
cryptoad edited edge metadata.Aug 28 2017, 4:46 PM

Thanks, it slipped my mind to update the doc. Couple of comments.

docs/ScudoHardenedAllocator.rst
145

(in Kb) in the description.

154

So here lower values will not necessarily lower the memory usage as we'll fill up to QuarantineSizeKb bytes anyway.
I'd go for "Size (in bytes) up to which chunks can be quarantined."

flowerhack updated this revision to Diff 112994.
flowerhack marked an inline comment as done.
flowerhack marked an inline comment as done.Aug 28 2017, 4:57 PM

Made requested fixes.

cryptoad accepted this revision.Aug 28 2017, 5:05 PM
This revision is now accepted and ready to land.Aug 28 2017, 5:05 PM

Do you have commit privileges or shall I fetch someone else?

cryptoad closed this revision.Aug 29 2017, 12:43 PM