This is an archive of the discontinued LLVM Phabricator instance.

Differential D35505

Add element-atomic mem intrinsic canary tests for Address Sanitizer.
ClosedPublic

Authored by dneilson on Jul 17 2017, 2:03 PM.

Details

Reviewers
reames
Commits
rG5fc2ee7fabef: Add element-atomic mem intrinsic canary tests for Address Sanitizer.
rL308248: Add element-atomic mem intrinsic canary tests for Address Sanitizer.
Summary

Add canary tests to verify that ASAN currently does nothing with the element atomic memory intrinsics for memcpy, memmove, and memset.

Placeholder tests that will fail once element atomic @llvm.mem[cpy|move|set] instrinsics have been added to the MemIntrinsic class hierarchy. These will act as a reminder to verify that ASAN handles these intrinsics properly once they have been added to that class hierarchy.

Diff Detail

Event Timeline

dneilson created this revision.Jul 17 2017, 2:03 PM
reames accepted this revision.Jul 17 2017, 2:05 PM

LGTM

This revision is now accepted and ready to land.Jul 17 2017, 2:05 PM
Closed by commit rL308248: Add element-atomic mem intrinsic canary tests for Address Sanitizer. (authored by dneilson). · Explain WhyJul 17 2017, 6:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
test/
Instrumentation/
AddressSanitizer/
20 lines

Diff 106946

test/Instrumentation/AddressSanitizer/basic.ll

Show First 20 Lines • Show All 164 Lines • ▼ Show 20 Lines
} }
; CHECK-LABEL: memintr_test ; CHECK-LABEL: memintr_test
; CHECK: __asan_memset ; CHECK: __asan_memset
; CHECK: __asan_memmove ; CHECK: __asan_memmove
; CHECK: __asan_memcpy ; CHECK: __asan_memcpy
; CHECK: ret void ; CHECK: ret void
declare void @llvm.memset.element.unordered.atomic.p0i8.i64(i8* nocapture writeonly, i8, i64, i32) nounwind
declare void @llvm.memmove.element.unordered.atomic.p0i8.p0i8.i64(i8* nocapture writeonly, i8* nocapture readonly, i64, i32) nounwind
declare void @llvm.memcpy.element.unordered.atomic.p0i8.p0i8.i64(i8* nocapture writeonly, i8* nocapture readonly, i64, i32) nounwind
define void @memintr_element_atomic_test(i8* %a, i8* %b) nounwind uwtable sanitize_address {
; This is a canary test to make sure that these don't get lowered into calls that don't
; have the element-atomic property. Eventually, asan will have to be enhanced to lower
; these properly.
; CHECK-LABEL: memintr_element_atomic_test
; CHECK-NEXT: tail call void @llvm.memset.element.unordered.atomic.p0i8.i64(i8* align 1 %a, i8 0, i64 100, i32 1)
; CHECK-NEXT: tail call void @llvm.memmove.element.unordered.atomic.p0i8.p0i8.i64(i8* align 1 %a, i8* align 1 %b, i64 100, i32 1)
; CHECK-NEXT: tail call void @llvm.memcpy.element.unordered.atomic.p0i8.p0i8.i64(i8* align 1 %a, i8* align 1 %b, i64 100, i32 1)
; CHECK-NEXT: ret void
tail call void @llvm.memset.element.unordered.atomic.p0i8.i64(i8* align 1 %a, i8 0, i64 100, i32 1)
tail call void @llvm.memmove.element.unordered.atomic.p0i8.p0i8.i64(i8* align 1 %a, i8* align 1 %b, i64 100, i32 1)
tail call void @llvm.memcpy.element.unordered.atomic.p0i8.p0i8.i64(i8* align 1 %a, i8* align 1 %b, i64 100, i32 1)
ret void
}
; CHECK-LABEL: @test_swifterror ; CHECK-LABEL: @test_swifterror
; CHECK-NOT: __asan_report_load ; CHECK-NOT: __asan_report_load
; CHECK: ret void ; CHECK: ret void
define void @test_swifterror(i8** swifterror) sanitize_address { define void @test_swifterror(i8** swifterror) sanitize_address {
%swifterror_ptr_value = load i8*, i8** %0 %swifterror_ptr_value = load i8*, i8** %0
ret void ret void
} }
Show All 23 Lines