This is an archive of the discontinued LLVM Phabricator instance.

Differential D35222

InstSimplify: canonicalize is idempotent
ClosedPublic

Authored by arsenm on Jul 10 2017, 1:36 PM.

Download Raw Diff

Details

Reviewers

scanon

Diff Detail

Event Timeline

arsenm created this revision.Jul 10 2017, 1:36 PM

Herald added a subscriber: wdng. · View Herald TranscriptJul 10 2017, 1:36 PM

ping

LGTM. Sorry that I didn't see this earlier.

This revision is now accepted and ready to land.Sep 6 2017, 8:30 AM

r312685

Revision Contents

Path

Size

lib/

Analysis/

InstructionSimplify.cpp

1 line

test/

Transforms/

InstSimplify/

call.ll

7 lines

Diff 105915

lib/Analysis/InstructionSimplify.cpp

Show First 20 Lines • Show All 4,291 Lines • ▼ Show 20 Lines	static bool IsIdempotent(Intrinsic::ID ID) {
// Unary idempotent: f(f(x)) = f(x)		// Unary idempotent: f(f(x)) = f(x)
case Intrinsic::fabs:		case Intrinsic::fabs:
case Intrinsic::floor:		case Intrinsic::floor:
case Intrinsic::ceil:		case Intrinsic::ceil:
case Intrinsic::trunc:		case Intrinsic::trunc:
case Intrinsic::rint:		case Intrinsic::rint:
case Intrinsic::nearbyint:		case Intrinsic::nearbyint:
case Intrinsic::round:		case Intrinsic::round:
		case Intrinsic::canonicalize:
return true;		return true;
}		}
}		}

static Value SimplifyRelativeLoad(Constant Ptr, Constant *Offset,		static Value SimplifyRelativeLoad(Constant Ptr, Constant *Offset,
const DataLayout &DL) {		const DataLayout &DL) {
GlobalValue *PtrSym;		GlobalValue *PtrSym;
APInt PtrOffset;		APInt PtrOffset;
▲ Show 20 Lines • Show All 480 Lines • Show Last 20 Lines

test/Transforms/InstSimplify/call.ll

Show First 20 Lines • Show All 236 Lines • ▼ Show 20 Lines


declare float @llvm.fabs.f32(float) nounwind readnone		declare float @llvm.fabs.f32(float) nounwind readnone
declare float @llvm.floor.f32(float) nounwind readnone		declare float @llvm.floor.f32(float) nounwind readnone
declare float @llvm.ceil.f32(float) nounwind readnone		declare float @llvm.ceil.f32(float) nounwind readnone
declare float @llvm.trunc.f32(float) nounwind readnone		declare float @llvm.trunc.f32(float) nounwind readnone
declare float @llvm.rint.f32(float) nounwind readnone		declare float @llvm.rint.f32(float) nounwind readnone
declare float @llvm.nearbyint.f32(float) nounwind readnone		declare float @llvm.nearbyint.f32(float) nounwind readnone
		declare float @llvm.canonicalize.f32(float) nounwind readnone

; Test idempotent intrinsics		; Test idempotent intrinsics
define float @test_idempotence(float %a) {		define float @test_idempotence(float %a) {
; CHECK-LABEL: @test_idempotence(		; CHECK-LABEL: @test_idempotence(
; CHECK-NEXT: [[A0:%.]] = call float @llvm.fabs.f32(float [[A:%.]])		; CHECK-NEXT: [[A0:%.]] = call float @llvm.fabs.f32(float [[A:%.]])
; CHECK-NEXT: [[B0:%.*]] = call float @llvm.floor.f32(float [[A]])		; CHECK-NEXT: [[B0:%.*]] = call float @llvm.floor.f32(float [[A]])
; CHECK-NEXT: [[C0:%.*]] = call float @llvm.ceil.f32(float [[A]])		; CHECK-NEXT: [[C0:%.*]] = call float @llvm.ceil.f32(float [[A]])
; CHECK-NEXT: [[D0:%.*]] = call float @llvm.trunc.f32(float [[A]])		; CHECK-NEXT: [[D0:%.*]] = call float @llvm.trunc.f32(float [[A]])
Show All 20 Lines	;
%d1 = call float @llvm.trunc.f32(float %d0)		%d1 = call float @llvm.trunc.f32(float %d0)

%e0 = call float @llvm.rint.f32(float %a)		%e0 = call float @llvm.rint.f32(float %a)
%e1 = call float @llvm.rint.f32(float %e0)		%e1 = call float @llvm.rint.f32(float %e0)

%f0 = call float @llvm.nearbyint.f32(float %a)		%f0 = call float @llvm.nearbyint.f32(float %a)
%f1 = call float @llvm.nearbyint.f32(float %f0)		%f1 = call float @llvm.nearbyint.f32(float %f0)

		%g0 = call float @llvm.canonicalize.f32(float %a)
		%g1 = call float @llvm.canonicalize.f32(float %g0)

%r0 = fadd float %a1, %b1		%r0 = fadd float %a1, %b1
%r1 = fadd float %r0, %c1		%r1 = fadd float %r0, %c1
%r2 = fadd float %r1, %d1		%r2 = fadd float %r1, %d1
%r3 = fadd float %r2, %e1		%r3 = fadd float %r2, %e1
%r4 = fadd float %r3, %f1		%r4 = fadd float %r3, %f1
		%r5 = fadd float %r4, %g1

ret float %r4		ret float %r5
}		}

define i8* @operator_new() {		define i8* @operator_new() {
; CHECK-LABEL: @operator_new(		; CHECK-LABEL: @operator_new(
; CHECK-NEXT: entry:		; CHECK-NEXT: entry:
; CHECK-NEXT: [[CALL:%.]] = tail call noalias i8 @_Znwm(i64 8)		; CHECK-NEXT: [[CALL:%.]] = tail call noalias i8 @_Znwm(i64 8)
; CHECK-NEXT: br i1 false, label [[CAST_END:%.]], label [[CAST_NOTNULL:%.]]		; CHECK-NEXT: br i1 false, label [[CAST_END:%.]], label [[CAST_NOTNULL:%.]]
; CHECK: cast.notnull:		; CHECK: cast.notnull:
▲ Show 20 Lines • Show All 150 Lines • Show Last 20 Lines