[Hexagon] Fix "LowerFormalArguments emitted a value with the wrong type!" assertion

[michaelwu]

Summary

When passing arguments (that aren't i32) by reference on the stack, SelectionDAGISel::LowerArguments asserts on the Hexagon backend due to the wrong type being used. -debug-only=isel is necessary to trigger the assertion.

[kparzysz]

Thanks!

[michaelwu]

I don't have commit access - can someone land this and D32000 for me?

llvm/trunk/lib/Target/Hexagon/HexagonISelLowering.cpp

if (   (VA.isRegLoc() && !Flags.isByVal())
 
       if (Flags.isByVal()) {
         // If it's a pass-by-value aggregate, then do not dereference the stack
         // location. Instead, we should generate a reference to the stack
         // location.
         InVals.push_back(FIN);
       } else {
         InVals.push_back(
-            DAG.getLoad(VA.getLocVT(), dl, Chain, FIN, MachinePointerInfo()));
+            DAG.getLoad(VA.getValVT(), dl, Chain, FIN, MachinePointerInfo()));
       }
     }
   }
 
   if (!MemOps.empty())
     Chain = DAG.getNode(ISD::TokenFactor, dl, MVT::Other, MemOps);
 
   if (isVarArg) {