Page MenuHomePhabricator

clang-format vs plugin support for Visual Studio 2017
ClosedPublic

Authored by hstefan on Mar 30 2017, 9:26 PM.

Details

Summary

With the release of Visual Studio 2017, we need to at the very least claim support for it in the current manifest file. With the changes introducted in this patch we can install the extension again, but a warning message will be shown stating that it's not supported (https://twitter.com/parsley72/status/846558416751411200).

To get the rid of the warning more work is necessary, as VS 2017 changed some things about extensions, see more here: https://docs.microsoft.com/en-us/visualstudio/extensibility/how-to-migrate-extensibility-projects-to-visual-studio-2017. I'm currently working on those changes, but it has been suggested in the mail list that this first patch is integrated in the meantime.

Diff Detail

Repository
rL LLVM

Event Timeline

hstefan created this revision.Mar 30 2017, 9:26 PM
hans accepted this revision.Mar 31 2017, 1:39 AM

Looks good to me.

Do you have commit access, or would you like me to commit it for you?

This revision is now accepted and ready to land.Mar 31 2017, 1:39 AM

Glad to hear it.

I don't have commit access, so I'd need someone to commit it for me.

This revision was automatically updated to reflect the committed changes.