Page MenuHomePhabricator

[libFuzzer] Fix minimize_crash issues.
AcceptedPublic

Authored by ochang on Jan 18 2017, 9:51 PM.

Details

Reviewers
aizatsky
Summary
  • Make size limits in minimize_crash more consistent.
  • Fix small enough units not being written to exact_artifact_path.

Diff Detail

Event Timeline

ochang created this revision.Jan 18 2017, 9:51 PM
ochang edited the summary of this revision. (Show Details)
ochang added inline comments.Jan 18 2017, 10:05 PM
FuzzerDriver.cpp
349

The loop in MinimizeCrashInput has this check:

if (U.size() < 2) {
  ...
  Printf("CRASH_MIN: '%s' is small enough\n", CurrentFilePath.c_str());

So this assert gets hit when the current item is size 2.

aizatsky accepted this revision.Jan 19 2017, 8:33 AM
aizatsky added a subscriber: aizatsky.

Do you need help landing it?

FuzzerDriver.cpp
303

pls change the summary to say smth like "saving small enough units". As far as I can see the issue was bigger than just artifact_path thing.

This revision is now accepted and ready to land.Jan 19 2017, 8:33 AM
ochang edited the summary of this revision. (Show Details)Jan 19 2017, 9:52 AM

Thanks for reviewing! Please help with landing this. I have no idea how to do so (or even if I can).