Page MenuHomePhabricator

[PM] Make default pipeline test strict
ClosedPublic

Authored by mkuper on Jan 18 2017, 7:05 PM.

Details

Summary

Use CHECK-NEXT to verify that a test breaks whenever unexpected passes, analyses, or invalidations show up in default pipelines.
The test case is constructed so that we don't expect to invalidate anything, and needs to be kept that way.

Diff Detail

Repository
rL LLVM

Event Timeline

mkuper created this revision.Jan 18 2017, 7:05 PM
chandlerc added inline comments.Jan 18 2017, 7:13 PM
test/Other/new-pm-defaults.ll
35–36 ↗(On Diff #84922)

Here and below you'll need a bunch of {{.*}} and just dropping the tail of the pass name. You can see the patterns that work in the original CHECK lines.

The type printing is good, but not perfect across platforms.

147 ↗(On Diff #84922)

Add some vertical space here for readability?

mkuper updated this revision to Diff 84997.Jan 19 2017, 11:15 AM
This revision is now accepted and ready to land.Jan 19 2017, 11:41 AM
This revision was automatically updated to reflect the committed changes.