Page MenuHomePhabricator

Fix weak symbol linkage in SBStructuredData, update docs.
ClosedPublic

Authored by tfiala on Nov 9 2016, 1:54 PM.

Details

Summary

This change fixes an issue where I was leaking a weakly-linked symbol in the SBAPI. It also updates the docs to call out what I did wrong.

Diff Detail

Repository
rL LLVM

Event Timeline

tfiala updated this revision to Diff 77389.Nov 9 2016, 1:54 PM
tfiala retitled this revision from to Fix weak symbol linkage in SBStructuredData, update docs..
tfiala updated this object.
tfiala added a reviewer: jingham.
tfiala added a subscriber: lldb-commits.
jingham edited edge metadata.Nov 9 2016, 2:10 PM

This is fine with one comment on the text.

SB-api-coding-rules.html
51–54 ↗(On Diff #77389)

I think it's more straightforward to say:

Please note that you should not put this Impl class in the lldb namespace. Failure to do so...

After all, it would be equally bad to have put it inside the "namespace lldb" but not in the class.

tfiala added a comment.Nov 9 2016, 3:10 PM

Making changes to the text...

SB-api-coding-rules.html
51–54 ↗(On Diff #77389)

Okay, I can use your verbiage. The end of one sentence did explicitly call out having it not be in the public lldb namespace:

"...but rather should be a separate class that is not present in the public lldb namespace."

but I think your prose is clearer, though. Thank you!

tfiala updated this revision to Diff 77405.Nov 9 2016, 3:14 PM
tfiala edited edge metadata.

Adjusted web docs.

jingham accepted this revision.Nov 9 2016, 3:21 PM
jingham edited edge metadata.

Looks good.

This revision is now accepted and ready to land.Nov 9 2016, 3:21 PM
tfiala added a comment.Nov 9 2016, 3:27 PM

Thanks, Jim!

This revision was automatically updated to reflect the committed changes.