This is an archive of the discontinued LLVM Phabricator instance.

Differential D25473

Fix test on non-x86 hosts
ClosedPublic

Authored by bogden on Oct 11 2016, 6:58 AM.

Download Raw Diff

Details

Reviewers

tejohnson

Commits

rG2cf7ca3f3527: Fix test on non-x86 hosts
rL283901: Fix test on non-x86 hosts

Summary

This test is allowed to run on non-x86 hosts and thus must use
llvm-nm rather than nm.

Diff Detail

Repository: rL LLVM

Event Timeline

bogden updated this revision to Diff 74246.Oct 11 2016, 6:58 AM

bogden retitled this revision from to Fix test on non-x86 hosts.

bogden updated this object.

Adding Teresa as it's her patch I'm messing with. Switching to llvm-nm seems the right thing to do -- output is identical to nm, but llvm-nm will work on binaries for any target supported in the llvm build.

LGTM, thanks

This revision is now accepted and ready to land.Oct 11 2016, 7:34 AM

Closed by commit rL283901: Fix test on non-x86 hosts (authored by bogden). · Explain WhyOct 11 2016, 9:41 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

llvm/

trunk/

test/

tools/

gold/

X86/

module_asm.ll

2 lines

Diff 74268

llvm/trunk/test/tools/gold/X86/module_asm.ll

	; RUN: llvm-as %s -o %t.o			; RUN: llvm-as %s -o %t.o
	; RUN: %gold -shared -m elf_x86_64 -o %t2 -plugin %llvmshlibdir/LLVMgold.so %t.o			; RUN: %gold -shared -m elf_x86_64 -o %t2 -plugin %llvmshlibdir/LLVMgold.so %t.o
	; RUN: nm %t2 \| FileCheck %s			; RUN: llvm-nm %t2 \| FileCheck %s
	; CHECK: PrepareAndDispatch			; CHECK: PrepareAndDispatch

	target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"			target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
	target triple = "x86_64-unknown-linux-gnu"			target triple = "x86_64-unknown-linux-gnu"

	module asm "call PrepareAndDispatch@plt"			module asm "call PrepareAndDispatch@plt"
	module asm "\09"			module asm "\09"