This is an archive of the discontinued LLVM Phabricator instance.

Let test pass for builds that support X86, but do not default to it
ClosedPublic

Authored by bogden on Oct 11 2016, 6:19 AM.

Download Raw Diff

Details

Reviewers

Commits

rGc5164132fe48: Let test pass for builds that support X86, but do not default to it
rL283902: Let test pass for builds that support X86, but do not default to it

Diff Detail

Repository: rL LLVM

Event Timeline

bogden updated this revision to Diff 74240.Oct 11 2016, 6:19 AM

bogden retitled this revision from to Let test pass for builds that support X86, but do not default to it.

bogden updated this object.

bogden updated this object.Oct 11 2016, 6:23 AM

bogden added a reviewer: rnk.

bogden updated this object.Oct 11 2016, 7:01 AM

This comment was removed by bogden.

This doesn't fail the public stage2 builds because they do not support X86 and so all the tests in this dir are skipped.

The tests that were added alongside this have any one of a set of 3 triples. Reid, please could you confirm that the triple I selected at random does not break the intent of the test.

lgtm

This revision is now accepted and ready to land.Oct 11 2016, 8:37 AM

Closed by commit rL283902: Let test pass for builds that support X86, but do not default to it (authored by bogden). · Explain WhyOct 11 2016, 9:43 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

llvm/

trunk/

test/

MC/

COFF/

cv-loc-cross-section.s

2 lines

Diff 74270

llvm/trunk/test/MC/COFF/cv-loc-cross-section.s

	# RUN: not llvm-mc < %s -o /dev/null 2>&1 \| FileCheck %s			# RUN: not llvm-mc -triple=x86_64-pc-win32 < %s -o /dev/null 2>&1 \| FileCheck %s

	.text			.text
	.global baz			.global baz
	baz:			baz:
	.Lfunc_begin0:			.Lfunc_begin0:
	.cv_file 1 "t.cpp"			.cv_file 1 "t.cpp"
	.cv_func_id 0			.cv_func_id 0
	.cv_loc 0 1 1 1			.cv_loc 0 1 1 1
	Show All 17 Lines