This is an archive of the discontinued LLVM Phabricator instance.

[StreamExecutor] Add Doxygen main page
ClosedPublic

Authored by jhen on Aug 30 2016, 5:54 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

jhen updated this revision to Diff 69790.Aug 30 2016, 5:54 PM
jhen retitled this revision from to [StreamExecutor] Add Doxygen main page.
jhen updated this object.
jhen added a reviewer: jlebar.
jhen added subscribers: parallel_libs-commits, jprice.
jhen updated this revision to Diff 69791.Aug 30 2016, 6:25 PM
  • Exclude examples, unittests from doc gen
jlebar added inline comments.Aug 31 2016, 9:30 AM
streamexecutor/examples/Example.cpp
44 ↗(On Diff #69791)

Not for this patch, but these seem like they might be good as helpers in some public header. (I see below that you're saying that users would want to convert to their own custom error-handling framework, but "getOrDie" does seem to be a pretty common way of "handling" errors.)

161 ↗(On Diff #69791)

It's really too bad that we have to do this manually. Would it be possible to make GlobalDeviceMemoryBase into an owning pointer? We have GlobalDeviceMemorySlice as our non-owning pointer...

jlebar accepted this revision.Aug 31 2016, 9:30 AM
jlebar edited edge metadata.
This revision is now accepted and ready to land.Aug 31 2016, 9:30 AM
jhen added inline comments.Aug 31 2016, 12:05 PM
streamexecutor/examples/Example.cpp
44 ↗(On Diff #69791)

Sure, I'll add them as global helpers in a later patch.

161 ↗(On Diff #69791)

I was thinking the same thing. I'll create a patch to make that change.

This revision was automatically updated to reflect the committed changes.