Page MenuHomePhabricator

NFC: refactor applyObjCProtocolQualifiers from SemaType.cpp to ASTContext so it can be shared.
ClosedPublic

Authored by manmanren on Aug 30 2016, 3:19 PM.

Details

Summary

To construct the canonical type of ObjCTypeParamType, we need to apply qualifiers on ObjCObjectPointerType. The updated applyObjCProtocolQualifiers handles this case by merging the protocol lists, constructing a new ObjCObjectType, then a new ObjCObjectPointerType.

Diff Detail

Repository
rL LLVM

Event Timeline

manmanren updated this revision to Diff 69766.Aug 30 2016, 3:19 PM
manmanren retitled this revision from to NFC: refactor applyObjCProtocolQualifiers from SemaType.cpp to ASTContext so it can be shared..
manmanren updated this object.
manmanren added a reviewer: doug.gregor.
manmanren added a subscriber: cfe-commits.
doug.gregor accepted this revision.Sep 12 2016, 4:07 PM
doug.gregor edited edge metadata.

Yep, this refactor looks good!

This revision is now accepted and ready to land.Sep 12 2016, 4:07 PM
This revision was automatically updated to reflect the committed changes.