GVN-hoist: only hoist relevant scalar instructions

[sebpop]

Summary

Without this patch, GVN-hoist would think that a branch instruction is a scalar instruction
and would try to value number it. The patch filters out all such kind of irrelevant instructions.

A bit frustrating is that there is no easy way to discard all those very infrequent instructions,
a bit like isa<TerminatorInst> that stands for a large family of instructions. I'm thinking that
checking for those very infrequent other instructions would cost us more in compilation time
than just letting those instructions getting numbered, so I'm still thinking that a simpler check:

if (isa<TerminatorInst>(I))
  return false;

is better than listing all the other less frequent instructions.

[sebpop]

Updated patch to only filter out TerminatorInst.
As I was mentioning, the other instructions are rare, and we would spend more time in isa<>() than allowing these instructions to be discarded after computing a VN.

llvm/trunk/lib/Transforms/Scalar/GVNHoist.cpp

std::pair<unsigned, unsigned> hoistExpressions(Function &F) {
     for (BasicBlock *BB : depth_first(&F.getEntryBlock())) {
       int InstructionNb = 0;
       for (Instruction &I1 : *BB) {
         // Only hoist the first instructions in BB up to MaxDepthInBB. Hoisting
         // deeper may increase the register pressure and compilation time.
         if (MaxDepthInBB != -1 && InstructionNb++ >= MaxDepthInBB)
           break;
 
+        // Do not value number terminator instructions.
+        if (!isa<TerminatorInst>(&I1))
+          break;
+
         if (auto *Load = dyn_cast<LoadInst>(&I1))
           LI.insert(Load, VN);
         else if (auto *Store = dyn_cast<StoreInst>(&I1))
           SI.insert(Store, VN);
         else if (auto *Call = dyn_cast<CallInst>(&I1)) {
           if (auto *Intr = dyn_cast<IntrinsicInst>(Call)) {
             if (isa<DbgInfoIntrinsic>(Intr) ||
                 Intr->getIntrinsicID() == Intrinsic::assume)

llvm/trunk/test/Transforms/GVNHoist/hoist-recursive-geps.ll

 ; RUN: opt -gvn-hoist -S < %s | FileCheck %s
 
 ; Check that recursive GEPs are hoisted.
 ; CHECK-LABEL: @fun
 ; CHECK: fdiv
 ; CHECK: load
 ; CHECK: load
 ; CHECK: load
 ; CHECK: load
 ; CHECK: fsub
-; CHECK: fmul
 ; CHECK: fsub
 ; CHECK: fmul
+; CHECK: fmul
 ; CHECK-NOT: fsub
 ; CHECK-NOT: fmul
 
 %0 = type { double, double, double }
 %1 = type { double, double, double }
 %2 = type { %3, %1, %1 }
 %3 = type { i32 (...)**, %4, %10*, %11, %11, %11, %11, %11, %11, %11, %11, %11 }
 %4 = type { %5 }