Page MenuHomePhabricator

Build clang Debug if we build lldb debug.
AbandonedPublic

Authored by sas on Jul 11 2016, 12:02 PM.

Details

Reviewers
clayborg
tfiala
Summary

When we build Debug, we might be tracking down bugs in clang/llvm as
well, so building it Debug with assertions helps debug the debugger.

Diff Detail

Event Timeline

sas updated this revision to Diff 63549.Jul 11 2016, 12:02 PM
sas retitled this revision from to Build clang Debug if we build lldb debug..
sas updated this object.
sas added reviewers: tfiala, clayborg.
sas added a subscriber: lldb-commits.
sas updated this revision to Diff 63550.Jul 11 2016, 12:09 PM

Remove leftover comment.

tfiala edited edge metadata.Jul 12 2016, 7:59 AM

We have a separate configuration for that build in Xcode - it is called DebugClang. You can build that configuration from the command line with something like:

xcodebuild --scheme desktop --configuration DebugClang

or clone the "desktop" scheme in Xcode, setting the scheme build option to use the DebugClang configuration instead of the Debug configuration.

Generally we don't want to force building a debug llvm/clang by default in the default Debug configuration since it has a noticeable impact on test run time.

@clayborg, thoughts on that?

clayborg requested changes to this revision.Jul 12 2016, 10:29 AM
clayborg edited edge metadata.

As Todd said, we already have a "DebugClang" configuration for this. We should abandon this change.

This revision now requires changes to proceed.Jul 12 2016, 10:29 AM
sas abandoned this revision.Jul 12 2016, 11:00 AM

Ah, makes sense, I had missed the DebugClang build configuration. Thanks for pointing this out.