Page MenuHomePhabricator

Add source file mapping to inline frames' SymbolContext line_entry.file
AbandonedPublic

Authored by ted on May 6 2016, 3:04 PM.

Details

Reviewers
jingham
Summary

new StackFrame objects created in StackFrameList::GetFramesUpTo are constructed with SymbolContext set to nullptr, except for inline frames. Calling the ctor with nullptr causes StackFrame::GetSymbolContext to apply the target.source-map to line_entry.file. Calling it with a valid SC will cause line_entry.file to have the original file from the DWARF info, so the file comparison in ThreadPlanStepRange::InRange will fail when it should succeed.

This patch adds the mapping from StackFrame::GetSymbolContext to the inline frame case in StackFrameList::GetFramesUpTo.

Diff Detail

Event Timeline

ted updated this revision to Diff 56468.May 6 2016, 3:04 PM
ted retitled this revision from to Add source file mapping to inline frames' SymbolContext line_entry.file.
ted updated this object.
ted added a reviewer: jingham.
ted added a subscriber: lldb-commits.
ted abandoned this revision.May 10 2016, 2:03 PM

Problem will be fixed in another way.