Page MenuHomePhabricator

Fixing Intel format of the vshufpd instruction
ClosedPublic

Authored by ygao on Sep 25 2013, 3:12 PM.

Details

Reviewers
ygao
Summary

Hi,
I noticed that the Intel format of the vshufpd instruction is incorrect.

For example,

$ echo "vshufpd XMM0, XMM0, XMM0, 1" | llvm-mc -x86-asm-syntax=intel
  error: invalid operand for instruction
  vshufpd XMM0, XMM0, XMM0, 1
          ^~~~

This seems to be caused by a typo in the tablegen entry for this instruction.

In lib/Target/X86/X86InstrSSE.td:

"shufpd\t{$src3, $src2, $src1, $dst|$dst, $src2, $src2, $src3}",

should be

"shufpd\t{$src3, $src2, $src1, $dst|$dst, $src1, $src2, $src3}",

Can someone take a look whether this patch is good to go in?

Thanks,

  • Gao

Diff Detail

Event Timeline

ygao accepted this revision.Oct 12 2016, 12:16 AM
ygao added a reviewer: ygao.

Closed by rL191481

This revision is now accepted and ready to land.Oct 12 2016, 12:16 AM
ygao closed this revision.Oct 12 2016, 12:16 AM