[RFC] Fix ASan interceptors for __pthread_mutex_lock|unlock

[azat]

Summary

In glibc 2.36 the behaviour of RTLD_NEXT had been changed after [1]
patch:

#define _GNU_SOURCE
#include <dlfcn.h>
#include <stdio.h>

int main()
{
    void *p = dlsym(RTLD_NEXT, "__pthread_mutex_lock");
    printf("__pthread_mutex_lock: %p (via RTLD_NEXT)\n", p);
    return 0;
}

Results:

libc 2.35: __pthread_mutex_lock: 0x7ffff7e27f70 (via RTLD_NEXT)
libc 2.36: __pthread_mutex_lock: (nil) (via RTLD_NEXT)

[1]: https://sourceware.org/git/?p=glibc.git;a=commit;h=efa7936e4c91b1c260d03614bb26858fbb8a0204

The problem is that now RTLD_NEXT does not return symbols that had been
marked as internal (like pthread_mutex_lock/pthread_mutex_unlock).

And so if you will use it in your program and try to build it with ASan
it will lead to NULL dereference.

And this is indeed what happened in case of ClickHouse. And even though
the fix is simple [2], looks like it is still worth to fix it in llvm
too (since it can take sometime to find this).

[2]: https://github.com/ClickHouse/ClickHouse/pull/44811

[azat]

Can someone elaborate, does my changes breaks CI? Does not looks like this is so.

https://buildkite.com/llvm-project/premerge-checks/builds/128429#01856ef2-9265-4964-99aa-7dd490f8ebcb

llvm-lit: /var/lib/buildkite-agent/builds/llvm-project/llvm/utils/lit/lit/llvm/subst.py:122: note: Did not find llvm-debuginfod in /var/lib/buildkite-agent/builds/llvm-project/build/bin
ERROR git-clang-format returned an non-zero exit code 1

[azat]

Closed in favor of D140957

compiler-rt/lib/sanitizer_common/sanitizer_common_interceptors.inc

INTERCEPTOR(int, __pthread_mutex_unlock, void *m) {
   COMMON_INTERCEPTOR_MUTEX_UNLOCK(ctx, m);
   int res = REAL(__pthread_mutex_unlock)(m);
   if (res == errno_EINVAL)
     COMMON_INTERCEPTOR_MUTEX_INVALID(ctx, m);
   return res;
 }
 
 #define INIT___PTHREAD_MUTEX_LOCK \
-  COMMON_INTERCEPT_FUNCTION(__pthread_mutex_lock)
+  COMMON_INTERCEPT_FUNCTION_GLIBC_VER_MIN(__pthread_mutex_lock, "GLIBC_2.2.5")
 #define INIT___PTHREAD_MUTEX_UNLOCK \
-  COMMON_INTERCEPT_FUNCTION(__pthread_mutex_unlock)
+  COMMON_INTERCEPT_FUNCTION_GLIBC_VER_MIN(__pthread_mutex_unlock, "GLIBC_2.2.5")
 #else
 #define INIT___PTHREAD_MUTEX_LOCK
 #define INIT___PTHREAD_MUTEX_UNLOCK
 #endif
 
 #if SANITIZER_INTERCEPT___LIBC_MUTEX
 INTERCEPTOR(int, __libc_mutex_lock, void *m)
 ALIAS(WRAPPER_NAME(pthread_mutex_lock));