This is an archive of the discontinued LLVM Phabricator instance.

Fix TestCompletion.py failure on Darwin after r246639
ClosedPublic

Authored by chying on Sep 2 2015, 7:13 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

chying updated this revision to Diff 33898.Sep 2 2015, 7:13 PM
chying retitled this revision from to Fix TestCompletion.py failure on Darwin after r246639.
chying updated this object.
chying added a reviewer: tberghammer.
chying added a subscriber: lldb-commits.
tberghammer accepted this revision.Sep 3 2015, 2:41 AM
tberghammer edited edge metadata.

I don't understand why it is necessary on OSX but I am fine with this change if it fixes the issue (at the moment I am struggling with building lldb on OSX so I can't test it).

One question: How many empty lines should we send? Is it always enough to send 2, or should we send the same number of empty lines then the number of lines in the original command?

This revision is now accepted and ready to land.Sep 3 2015, 2:41 AM

Based on experiment I had, we need to send empty lines the same times as the number of lines in original commands on Darwin.
But on Linux, only one empty line is needed for multiple lines of commands.
It seems on Darwin, lldb doesn't automatically execute commands separated by new line.

This revision was automatically updated to reflect the committed changes.