Page MenuHomePhabricator

[FaultMaps] Move FaultMapParser to Object/
ClosedPublic

Authored by sanjoy on Jun 22 2015, 4:19 PM.

Details

Summary

That way llvm-objdump can rely on it without adding an extra dependency
on CodeGen.

This change duplicates the FaultKind enum and the code that serializes
it to a string. I could not figure out a way to get around this without
adding a new dependency to Object

Diff Detail

Repository
rL LLVM

Event Timeline

sanjoy updated this revision to Diff 28168.Jun 22 2015, 4:19 PM
sanjoy retitled this revision from to [FaultMaps] Move FaultMapParser to Object/.
sanjoy updated this object.
sanjoy edited the test plan for this revision. (Show Details)
sanjoy added reviewers: rafael, ab.
sanjoy added a subscriber: Unknown Object (MLST).
ab edited edge metadata.Jun 22 2015, 4:35 PM

Fixes it indeed, thanks!

The duplication does seems icky, but I don't know of a good place to share it. Rafael?

include/llvm/Object/FaultMapParser.h
168 ↗(On Diff #28168)

Unnecessary whitespace?

I think I'll check this in -- I don't want to keep the shared-object build broken any longer.

If there is a better way to solve this, then we can come back and do that later.

This revision was automatically updated to reflect the committed changes.