This is an archive of the discontinued LLVM Phabricator instance.

Fix returning error message in LLVMLinkModules
ClosedPublic

Authored by pitrou on Jun 4 2015, 6:02 AM.

Details

Summary

On error, the temporary output stream wouldn't be flushed and therefore the caller would see an empty error message.

Diff Detail

Repository
rL LLVM

Event Timeline

pitrou updated this revision to Diff 27111.Jun 4 2015, 6:02 AM
pitrou retitled this revision from to Fix returning error message in LLVMLinkModules.
pitrou updated this object.
pitrou edited the test plan for this revision. (Show Details)
pitrou set the repository for this revision to rL LLVM.
pitrou added a subscriber: Unknown Object (MLST).
pitrou added a subscriber: eliben.Jun 9 2015, 12:07 PM
eliben accepted this revision.Jun 10 2015, 8:43 AM
eliben added a reviewer: eliben.

LGTM

This revision is now accepted and ready to land.Jun 10 2015, 8:43 AM
This revision was automatically updated to reflect the committed changes.

Thanks for committing this, and sorry for the leak!