This is an archive of the discontinued LLVM Phabricator instance.

Refactor: Simplify boolean conditional return statements in llvm/lib/Bitcode/Reader
ClosedPublic

Authored by LegalizeAdulthood on May 24 2015, 11:43 PM.

Reviewers

Summary

Use clang-tidy to simplify boolean conditional return statements.

LegalizeAdulthood retitled this revision from to Refactor: Simplify boolean conditional return statements in llvm/lib/Bitcode/Reader.

LegalizeAdulthood updated this object.

LegalizeAdulthood edited the test plan for this revision. (Show Details)

LegalizeAdulthood added a subscriber: Unknown Object (MLST).

LGTM

Can someone commit this for me, please?

Richard Thomson <legalize@xmission.com>

This got committed as r238134.

This revision is now accepted and ready to land.Jul 25 2015, 1:04 PM

Path

Size

lib/

Bitcode/

Reader/

5 lines

Show First 20 Lines • Show All 42 Lines • ▼ Show 20 Lines	bool BitstreamCursor::EnterSubBlock(unsigned BlockID, unsigned *NumWordsP) {
if (CurCodeSize > MaxChunkSize)		if (CurCodeSize > MaxChunkSize)
return true;		return true;

SkipToFourByteBoundary();		SkipToFourByteBoundary();
unsigned NumWords = Read(bitc::BlockSizeWidth);		unsigned NumWords = Read(bitc::BlockSizeWidth);
if (NumWordsP) *NumWordsP = NumWords;		if (NumWordsP) *NumWordsP = NumWords;

// Validate that this block is sane.		// Validate that this block is sane.
if (CurCodeSize == 0 \|\| AtEndOfStream())		return CurCodeSize == 0 \|\| AtEndOfStream();
return true;

return false;
}		}

static uint64_t readAbbreviatedField(BitstreamCursor &Cursor,		static uint64_t readAbbreviatedField(BitstreamCursor &Cursor,
const BitCodeAbbrevOp &Op) {		const BitCodeAbbrevOp &Op) {
assert(!Op.isLiteral() && "Not to be used with literals!");		assert(!Op.isLiteral() && "Not to be used with literals!");

// Decode the value as we are commanded.		// Decode the value as we are commanded.
switch (Op.getEncoding()) {		switch (Op.getEncoding()) {
▲ Show 20 Lines • Show All 296 Lines • Show Last 20 Lines