This is an archive of the discontinued LLVM Phabricator instance.

Add support for VSX scalar single-precision arithmetic in the PPC target
ClosedPublic

Authored by nemanjai on May 20 2015, 12:52 PM.

Details

Summary

As a follow-up to the VSX scalar loads and stores, this patch adds the elementary VSX scalar single-precision arithmetic instructions.

Also, I've fixed up some spacing that was weird in this section of PPCInstrVSX.td.

Diff Detail

Repository
rL LLVM

Event Timeline

nemanjai updated this revision to Diff 26171.May 20 2015, 12:52 PM
nemanjai retitled this revision from to Add support for VSX scalar single-precision arithmetic in the PPC target.
nemanjai updated this object.
nemanjai edited the test plan for this revision. (Show Details)
nemanjai added reviewers: wschmidt, hfinkel, kbarton, seurer.
nemanjai set the repository for this revision to rL LLVM.
nemanjai added a subscriber: Unknown Object (MLST).
kbarton edited edge metadata.May 20 2015, 7:40 PM

The only (very minor) comment I have would be to list the specific instructions added in the summary in case someone is looking this up through the SVN history logs.

Aside from that, this looks good to me.

wschmidt accepted this revision.May 21 2015, 8:14 AM
wschmidt edited edge metadata.

LGTM!

This revision is now accepted and ready to land.May 21 2015, 8:14 AM

Good point, thank you Kit. I'll list them here (as well as in the commit message). Instructions added:
xsaddsp
xsdivsp
xsmulsp
xsresp
xsrsqrtesp
xssqrtsp
xssubsp

nemanjai closed this revision.May 21 2015, 12:36 PM

Committed revision 237937.