Page MenuHomePhabricator

Mark gc.relocate and gc.result as readnone (try 2)
ClosedPublic

Authored by reames on Mar 16 2021, 11:47 AM.

Details

Summary

As noted in the LangRef, these are semantically readnone projections from the result value of the associated statepoint. However, it turned out we had a few latent bugs being covered up by the fact we were only marking them readonly (see PR49607 for context).

As of this change, all known issues are resolved. This is a deliberately minimal patch to make it easy to test downstream and revert with minimal change if that turns out to be necessary.

Depends on:

  • D98728 [LICM] Fix a crash when sinking instructions w/token operands

Diff Detail

Event Timeline

reames created this revision.Mar 16 2021, 11:47 AM
reames requested review of this revision.Mar 16 2021, 11:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 16 2021, 11:47 AM
Herald added a subscriber: jdoerfert. · View Herald Transcript
skatkov accepted this revision.Wed, Mar 24, 8:01 PM

Hi Philip, at the moment my downstream testing did not show any problems.

So I guess we can try and land it. In case some troubles I'll revert this change back.

This revision is now accepted and ready to land.Wed, Mar 24, 8:01 PM
This revision was landed with ongoing or failed builds.Thu, Mar 25, 2:51 PM
This revision was automatically updated to reflect the committed changes.