This is an archive of the discontinued LLVM Phabricator instance.

[GDBRemoteCommunicationClient] Increase timeout for qfProcessInfo packet.
ClosedPublic

Authored by sivachandra on May 19 2015, 3:41 PM.

Details

Summary

The test in TestPlatformCommand which runs "platform process list" has
been timing out for Android when running running dosep.py with
LLDB_TEST_THREADS=8. This patch increases the packet timeout to a large
value of 1min to accommodate the long time required for a response for
the qfProcessInfo packet on Android.

Diff Detail

Event Timeline

sivachandra retitled this revision from to [GDBRemoteCommunicationClient] Increase timeout for qfProcessInfo packet..
sivachandra updated this object.
sivachandra edited the test plan for this revision. (Show Details)
sivachandra added a reviewer: chaoren.
sivachandra added a subscriber: Unknown Object (MLST).
chaoren accepted this revision.May 19 2015, 3:51 PM
chaoren edited edge metadata.
chaoren added inline comments.
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
2699

I think it would be good to have a per-platform default timeout value, so we don't need a global change to accommodate one particularly slow platform.

This revision is now accepted and ready to land.May 19 2015, 3:51 PM
sivachandra closed this revision.May 19 2015, 5:34 PM
tberghammer added inline comments.May 20 2015, 2:07 AM
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
2699

We already have a platform specific default packet timeout specified in GDBRemoteCommunicationServerCommon and I don't think it would be a good idea to increase that one further just because of one slow packet. As a long term solution I would prefer to rework the communication timeout handling in LLDB because a timeout almost always cause issues in a later stage when the response packet came in with a huge delay.